Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conn: fix UDP port byteorder in recvfrom #4324

Merged
merged 1 commit into from
Nov 23, 2015
Merged

conn: fix UDP port byteorder in recvfrom #4324

merged 1 commit into from
Nov 23, 2015

Conversation

OlegHahm
Copy link
Member

Additionally cleans up some superfluous functions.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: POSIX Area: POSIX API wrapper Area: network Area: Networking Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 20, 2015
@OlegHahm OlegHahm added this to the Release 2015.12 milestone Nov 20, 2015
@OlegHahm OlegHahm mentioned this pull request Nov 20, 2015
Merged
@OlegHahm
conn: fix UDP port byteorder in recvfrom
9d1dd39 
Additionally cleans up some superfluous functions.
@OlegHahm OlegHahm force-pushed the posix_socket_recvfrom_byte_order branch from 87efbe3 to 9d1dd39 Compare November 20, 2015 21:44
@OlegHahm OlegHahm mentioned this pull request Nov 20, 2015
Closed
@miri64
Copy link
Member

miri64 commented Nov 21, 2015

Can you run the conn_ip test please? I'm not so sure these functions are superfluous.

@OlegHahm
Copy link
Member Author

Can you run the conn_ip test please?

Verified.

@PeterKietzmann
Copy link
Member

Shouldn't that also be fixed for the release branch?

@OlegHahm
Copy link
Member Author

Yes, you're absolutely right. Can you set the label, please? I don't have access to Github right now.

On 23 November 2015 08:42:57 CET, Peter Kietzmann notifications@github.com wrote:

Shouldn't that also be fixed for the release branch?

Reply to this email directly or view it on GitHub:
#4324 (comment)

Join the RIOT
http://www.riot-os.org

@kaspar030
Copy link
Contributor

Confirmed working with the (adapted) microcoap example in #4287. ACK.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 23, 2015
OlegHahm added a commit that referenced this pull request Nov 23, 2015
@OlegHahm
Merge pull request #4324 from OlegHahm/posix_socket_recvfrom_byte_order
4fd7cfe 
conn: fix UDP port byteorder in recvfrom
@OlegHahm OlegHahm merged commit 4fd7cfe into RIOT-OS:master Nov 23, 2015
@OlegHahm OlegHahm deleted the posix_socket_recvfrom_byte_order branch November 23, 2015 19:24
@OlegHahm OlegHahm mentioned this pull request Nov 23, 2015
Merged
@cgundogan cgundogan removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: network Area: Networking Area: POSIX Area: POSIX API wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.
5 participants
@OlegHahm @miri64 @PeterKietzmann @kaspar030 @cgundogan