Link layer interfaces #460

miri64 · 2013-12-20T14:44:01Z

Currently every module above link layer defines their ways to communicate with the transceivers. This results e. g. that the sixlowpan module to this day basically just speaks to cc1100 (and if not, it treets the transceiver like one). To abstract from this I introduced an interface layer similar to the network interfaces in unixoid operating systems. It is basically a wrapper for the transceiver module, with the capability to associate certain upper layer addresses with the a transceiver.

mehlis · 2013-12-21T14:54:23Z

@authmillenon let's put the discussion about this multiplexer in the next year.

miri64 · 2013-12-22T13:09:12Z

It was not meant for this release anyways ;-)

miri64 · 2013-12-23T16:30:13Z

No longer WIP. Test project is des-testbed/RIOT-projects#84

miri64 · 2013-12-27T11:44:40Z

Added some more functions and make shell commands (untested)

miri64 · 2014-01-21T17:14:35Z

Again WIP!

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

mehlis · 2014-01-27T19:53:09Z

style changes in own commit
in some files your "@author" field is missing

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

miri64 · 2014-01-31T14:22:12Z

@mehlis which style changes (apart from the ones introduced in #557 on which this PR is dependent) do you mean exactly?

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

miri64 · 2014-02-02T20:45:55Z

Again no longer WIP

miri64 · 2014-02-02T20:50:21Z

Known issue: build test fails for all boards where I don't know the transceiver.

LudwigKnuepfer · 2014-02-03T08:02:24Z

Known issue: build test fails for all boards where I don't know the transceiver.

How about implementing #432

miri64 · 2014-02-03T09:37:35Z

The problem is that the modules for the radio drivers are not added in the makefile ;) so your proposal would not work either (i'm technically doing this in auto_init)

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

LudwigKnuepfer · 2014-02-03T13:18:49Z

Your answer is due to a lack of creativity when reading the issue ;-) Let's discuss this over at that issue.

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

miri64 · 2014-02-04T21:15:39Z

Rebased and changing NET_IF_L3P_ a bit.

OlegHahm · 2014-02-27T15:10:45Z

sys/shell/commands/sc_transceiver.c

+    mesg.content.ptr = (char *) &tcmd;
+
+    if (argc > 1) {
+        a = atoll(argv[1]);


RIOT/sys/shell/commands/sc_transceiver.c:100: undefined reference to atoll'
on MSP-430 platforms.

OlegHahm · 2014-02-27T15:34:11Z

On MSB-A2 and examples/default
USEMODULE+=net_if PORT=/dev/ttyUSB0 BOARD=msba2 make

ifconfig 0
2014-02-27 16:32:52,440 - INFO # > ifconfig 0
2014-02-27 16:32:52,442 - INFO # Error reading interface 0

Rest seems to work fine.

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

miri64 · 2014-02-27T17:23:30Z

~~@OlegHahm on current version it is working fine.~~
I redifined how net_if_get_pan_id() works on platforms without IEEE 802.15.4, so now it should not be a problem anymore.

LudwigKnuepfer · 2014-02-27T17:29:40Z

tests/test_net_if/Makefile

@@ -0,0 +1,50 @@
+####


Obsolete style test Makefile

Not good enough - have a look at the other test Makefiles, or this: #759

OlegHahm · 2014-02-27T22:31:49Z

For msp-430:

inet_pton.c:186:9: error: unknown type name `ssize_t'

I guess this needs an #include "kernel.h"

miri64 · 2014-02-27T23:18:06Z

Not part of this PR, but here is the fix: #808.

OlegHahm · 2014-02-28T12:02:14Z

Wouldn't it make more sense to have this as a part of this PR (and squashed into one of it's commits) to avoid non-compilable revisons (which are nasty for git bisect)?

OlegHahm · 2014-02-28T12:07:31Z

Or we merge #808 first... ;)

miri64 · 2014-02-28T12:13:47Z

merge #808 first ;-)

OlegHahm · 2014-02-28T12:38:59Z

sys/auto_init/auto_init.c

+        int iface = net_if_init_interface(0, transceivers);
+
+        if (iface >= 0) {
+            DEBUG("Interface %d initialized\n", iface)


IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

OlegHahm · 2014-02-28T12:42:09Z

Apart from the missing ; in DEBUG code: ACK.

Ready to be merged in my eyes.

miri64 · 2014-02-28T12:51:42Z

(Don't forget: without #644 the IoT network stack won't work)

OlegHahm · 2014-02-28T13:13:37Z

Thanks for the reminder. I'll try to review the other two PRs today and would suggest to merge them within a short time frame.

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

miri64 · 2014-02-28T13:45:49Z

@OlegHahm please comment on file changes, not on commits ;-)

LudwigKnuepfer · 2014-02-28T13:55:25Z

Makefile.dep

@@ -102,3 +102,15 @@ ifneq (,$(filter vtimer,$(USEMODULE)))
 		USEMODULE += timex
 	endif
 endif
+
+ifneq (,$(findstring net_if,$(USEMODULE)))


use filter instead

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

LudwigKnuepfer · 2014-03-01T14:44:37Z

tests/test_net_if/Makefile

+
+export INCLUDES += -I$(RIOTBASE)/sys/net/include
+
+ifeq ($(BOARD),msba2)


This is superfluous.

Link layer interfaces

IEEE 802.15.4 has two addressing modes: 16-bit short and the device's EUI-64. Currently RIOT supports only sending of packets with 16-bit short addresses via the transceiver interface. This patch allows at least for the radio chips that support IEEE 802.15.4 to let the application/upper layer decide which addressing mode to use. Upper layer implementation will be implemented in follow-up PR to RIOT-OS#460

OlegHahm mentioned this pull request Dec 20, 2013

Enforce disjuncture of non-neighbouring layers #131

Closed

miri64 mentioned this pull request Dec 23, 2013

Eliminate redundant functions #469

Closed

miri64 mentioned this pull request Dec 23, 2013

Add test project for module net_if des-testbed/RIOT-projects#84

Closed

miri64 mentioned this pull request Jan 18, 2014

Deal with stdin in bordermultiplex.c #21

Closed

miri64 mentioned this pull request Jan 24, 2014

Allow IEEE 802.15.4 addressing types for transceiver #557

Merged

miri64 mentioned this pull request Feb 2, 2014

destiny_socket_sendto() falsely returns value != -1 #604

Closed

miri64 mentioned this pull request Feb 4, 2014

Generate EUI-64 fromy TAP's MAC address in native #621

Closed

OlegHahm reviewed Feb 27, 2014
View reviewed changes

LudwigKnuepfer reviewed Feb 27, 2014
View reviewed changes

OlegHahm reviewed Feb 28, 2014
View reviewed changes

Fix coding conventions in sys/transceiver/transceiver.c

1e4badf

LudwigKnuepfer reviewed Feb 28, 2014
View reviewed changes

Martin Lenders and others added 5 commits February 28, 2014 23:13

Add getter and setter of long addresses to transceiver

7f8e2c2

Implement net_if module

848ac70

Add shell commands for interface configuration

4a64959

Add test cases for net_if module

a5e0e92

LudwigKnuepfer reviewed Mar 1, 2014
View reviewed changes

tests/test_net_if/Makefile

export INCLUDES += -I$(RIOTBASE)/sys/net/include

ifeq ($(BOARD),msba2)

Copy link

Member

LudwigKnuepfer Mar 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superfluous.

miri64 added a commit that referenced this pull request Mar 1, 2014

Merge pull request #460 from authmillenon/define_ll_ifs

eaa8660

Link layer interfaces

miri64 merged commit eaa8660 into RIOT-OS:master Mar 1, 2014

miri64 deleted the define_ll_ifs branch March 1, 2014 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Link layer interfaces #460

Link layer interfaces #460

miri64 commented Dec 20, 2013

mehlis commented Dec 21, 2013

miri64 commented Dec 22, 2013

miri64 commented Dec 23, 2013

miri64 commented Dec 27, 2013

miri64 commented Jan 21, 2014

mehlis commented Jan 27, 2014

miri64 commented Jan 31, 2014

miri64 commented Feb 2, 2014

miri64 commented Feb 2, 2014

LudwigKnuepfer commented Feb 3, 2014

miri64 commented Feb 3, 2014

LudwigKnuepfer commented Feb 3, 2014

miri64 commented Feb 4, 2014

OlegHahm Feb 27, 2014

miri64 Feb 27, 2014

OlegHahm commented Feb 27, 2014

miri64 commented Feb 27, 2014

LudwigKnuepfer Feb 27, 2014

miri64 Feb 27, 2014

LudwigKnuepfer Feb 27, 2014

OlegHahm commented Feb 27, 2014

miri64 commented Feb 27, 2014

OlegHahm commented Feb 28, 2014

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

OlegHahm Feb 28, 2014

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

LudwigKnuepfer Feb 28, 2014

LudwigKnuepfer Mar 1, 2014


		export INCLUDES += -I$(RIOTBASE)/sys/net/include

		ifeq ($(BOARD),msba2)

Link layer interfaces #460

Link layer interfaces #460

Conversation

miri64 commented Dec 20, 2013

mehlis commented Dec 21, 2013

miri64 commented Dec 22, 2013

miri64 commented Dec 23, 2013

miri64 commented Dec 27, 2013

miri64 commented Jan 21, 2014

mehlis commented Jan 27, 2014

miri64 commented Jan 31, 2014

miri64 commented Feb 2, 2014

miri64 commented Feb 2, 2014

LudwigKnuepfer commented Feb 3, 2014

miri64 commented Feb 3, 2014

LudwigKnuepfer commented Feb 3, 2014

miri64 commented Feb 4, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlegHahm commented Feb 27, 2014

miri64 commented Feb 27, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlegHahm commented Feb 27, 2014

miri64 commented Feb 27, 2014

OlegHahm commented Feb 28, 2014

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

Choose a reason for hiding this comment

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

OlegHahm commented Feb 28, 2014

miri64 commented Feb 28, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment