gnrc: use gnrc_netapi_dispatch_send() instead of manual iteration #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
miri64
force-pushed
the
gnrc/enh/dispatch-send
branch
from
d93e93e to
890a237
Compare
|
There was a little bug introduced that is fixed in the latest iteration. |
| @@ -168,7 +168,6 @@ void gnrc_ipv6_demux(kernel_pid_t iface, gnrc_pktsnip_t *current, gnrc_pktsnip_t | |||
| case PROTNUM_ICMPV6: | |||
| DEBUG("ipv6: handle ICMPv6 packet (nh = %u)\n", nh); | |||
| gnrc_icmpv6_demux(iface, pkt); | |||
| gnrc_pktbuf_release(pkt); | |||
There was a problem hiding this comment.
This removal was necessary because there isn't the release [hold] we had in https://github.com/RIOT-OS/RIOT/pull/5525/files#diff-9af59eae807169797112fdc7b1ca9504L140. Additionally, this simplifies a lot since we return to the event loop here anyways.
|
Tested quickly on native, pinging still works. It looks good code-wise and removes a lot of clutter. ACK! Please address my comment and then set the CI flag. |
miri64
force-pushed
the
gnrc/enh/dispatch-send
branch
from
890a237 to
bd230d3
Compare
|
Addressed and squashed immediately. |
miri64
added
the
CI: ready for build
|
Murdock does not seem to finish... |
miri64
added
CI: ready for build
Merged
kaspar030
added
CI: ready for build
It broke on #5747 (some weird synchronization error). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were still some occurrences of manual lookup in
gnrc_netreginside and in the usage of GNRC, that need not to be. This PR fixes that (and is also, like #5524 a preperation step forgnrc_netregwithmboxes)