cpu/sam21: removed superfluous gpio_init_sercom #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was a duplication of the existing gpio_init_mux, where the exiting function is the more general one, as the mux inititalization is not only valid for the sercom module...
haukepetersen
added
Platform: ARM
PeterKietzmann
added
the
CI: ready for build
|
ACK from my side. Tested with gnrc_networking on a samr21-xpro. However, I'd like to wait for @keestux before approving this PR |
keestux
approved these changes
Oct 6, 2016
PeterKietzmann
approved these changes
Oct 7, 2016
|
Thanks for your feedback @keestux. ACK and go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5743 introduced some inconsistencies, one step towards cleanup...
The
gpio_init_sercomfunction was a duplication of the existing gpio_init_mux, where the exiting function is the more general one, as the mux inititalization is not only valid for the sercom module...