-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: Add support for specifying a different compiler for assembler #6672
Conversation
Couldn't we just use gcc as AS? |
I did not try to change any behaviour, just allow us to specify a separate compiler for assembler sources being built with gcc (*.S). There are assembly sources built using as too, these are named *.s, lowercase s. |
Ping @kaspar030 |
Just so I understand, there are some assembly files in the MIPS code that clang doesn't like, but gcc compiles fine? Can we get rid of ASSMSRC vs ASMSRC? gcc invokes gnu as, clang invokes the llvm assembler. Both run the preprocessor on *.S, not on *.s. |
Correct
Yes, let's do that. |
But could we merge this in the meantime while we work on that change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
This will allow us to specify a separate compiler for assembly sources which are compiled with GCC (not AS). Clang has a problem with some of the assembly headers in the MIPS port and using GCC for the asm sources instead will allow Clang to build all of the C code. PR on the MIPS part is coming.