net/nanocoap: Options sort module #9475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kb2ma
added
Type: enhancement
|
please rebase |
|
@smlng, thanks for the ping. Unless you object, I plan to close this PR. I don't see the need for it that I originally anticipated. We can always reinstate it later. |
|
if this is obsolete or not required, please close. |
|
This PR may be useful at some point, but it's a distraction for now. If anyone in the future would like to pursue it, feel free to add a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Allows the user to add CoAP Options out of option number order via the
coap_opt_add_[string|uint](pkt, ...)functions. Implemented within the nanocoap_opt2_sort module.Conceptually, this PR accomplishes the same goal as #9144. However, I simplified the implementation based on test results. This PR automatically checks the sort order in
coap_opt_finish()and sorts if necessary.Issues/PRs references
Based on #9474. Supersedes #9144. Implements ideas described in #9048 and #8831.