Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/hashes/sha256: replace include by stddef.h #9893

Merged
merged 1 commit into from
Sep 6, 2018
Merged

sys/hashes/sha256: replace include by stddef.h #9893

merged 1 commit into from
Sep 6, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Sep 6, 2018

Contribution description

stddef.h is enough for size_t, unistd.h adds a lot of other declarations as described in #9891 (comment)

Testing procedure

Compile an application that only includes "hashes/sha256.h"

make
Building application "sha256" for "wsn430-v1_3b" with MCU "msp430fxyz".

In file included from /home/cladmi/git/work/RIOT_test/examples/sha256/main.c:1:0:
/home/cladmi/git/work/RIOT_test/sys/include/hashes/sha256.h:89:5: error: unknown type name 'size_t'
/home/cladmi/git/work/RIOT_test/sys/include/hashes/sha256.h:108:61: error: unknown type name 'size_t'

Issues/PRs references

Comment #9891 (comment)

@cladmi
sys/hashes/sha256: replace include by stddef.h
a052801 
stddef.h is enough for size_t, unistd.h adds a lot of other declarations
@cladmi cladmi added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 6, 2018
jnohlgard
jnohlgard approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@cladmi cladmi requested a review from kYc0o September 6, 2018 13:10
@kYc0o
Copy link
Contributor

kYc0o commented Sep 6, 2018

Let's go again! I merged the previous one because it's a very straightforward PR, which shouldn't stale. Thanks @gebart for the remark!

@kYc0o kYc0o merged commit f0cf15e into RIOT-OS:master Sep 6, 2018
@cladmi cladmi deleted the pr/sha256/fixup_include branch September 6, 2018 14:32
@jia200x jia200x added this to the Release 2018.10 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@kYc0o kYc0o Awaiting requested review from kYc0o

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
4 participants
@cladmi @kYc0o @jnohlgard @jia200x