Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: hierarchical structuring of the test directory #9933

Closed
wants to merge 5 commits into from

Conversation

OlegHahm
Copy link
Member

Contribution description

The list of directories inside the tests folder has become really, really long and difficult to oversee. Hence, I propose to introduce some sub-directories to logically order the tests into groups represented by directories.

Introduce some hierarchical structuring to the tests folder.
@OlegHahm OlegHahm added the Area: tests Area: tests and testing framework label Sep 14, 2018
@OlegHahm OlegHahm added Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 14, 2018
@OlegHahm OlegHahm changed the title [RFC] tests: hierarchical structuring of the test directory tests: hierarchical structuring of the test directory Sep 14, 2018
@cladmi
Copy link
Contributor

cladmi commented Sep 25, 2018

I fixed the other flake8 complains.

@cladmi
Copy link
Contributor

cladmi commented Sep 25, 2018

A first note, is that the new tests directories should be added to https://github.com/RIOT-OS/RIOT/blob/bbc16cced2c994ec57e0e7808e788932407c8885/makefiles/app_dirs.inc.mk to be detected by murdock and compile_test.
To make this more flexible, I am thinking about adding sub-files to declare this applications patterns. Like tests could have a file saying include the files in this directories, and each directory says, there are applications in these ones.

I like the idea of re-organizing the tests but with the current state I have a bit mixed feeling as there are still a lot of tests directories and directories with tests inside so an in between situation. So maybe go even further with the directory re-organization.

For packages I am also thinking of putting the tests in each package directory to move toward self contained packages. But it would require the modular definition of APPLICATION_DIRS I think.

@MrKevinWeiss
Copy link
Contributor

I like nesting. I think if we can get consensus from enough people then schedule a time to get this done because I can imagine hitting a moving target is difficult.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants