This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
sniffer: use fmt instead of printf #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested new stacksize on |
|
needs rebase |
|
Rebased (and adapted) |
jnohlgard
approved these changes
Jun 19, 2018
jnohlgard
reviewed
Jun 19, 2018
| @@ -45,7 +47,7 @@ | |||
| /** | |||
| * @brief Stack for the raw dump thread | |||
| */ | |||
| static char rawdmp_stack[THREAD_STACKSIZE_MAIN]; | |||
| static char rawdmp_stack[THREAD_STACKSIZE_SMALL]; | |||
There was a problem hiding this comment.
This change may need verification on some more platforms though (AVR, msp430, mips)
There was a problem hiding this comment.
z1 is an msp430 platform, so this I already tested. I'm not sure XBee works with the sniffer, but we can maybe try with an OpenLabs for the AVR-based board. Same goes probably for MIPS, though SPI is just in the works.
There was a problem hiding this comment.
The z1 would even be happy with THREAD_STACKSIZE_TINY btw ;-)
|
Ping |
I was able to reduce stack usage by 2/3 on `samr21-xpro`. Additionally, I removed the leading `0x` for the hexadecimal numbers. The parsing script knows which numbers are hex (all of them) and they just waste time both on the node and in the parsing script
miri64
force-pushed
the
sniffer/enh/fmt
branch
from
755d7d4 to
c65dc82
Compare
|
Ping and rebased. |
|
sorry for the delay, I forgot about this one. |
chrysn
pushed a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Sep 20, 2022
sniffer: use fmt instead of printf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a little more extreme change, but I was able to reduce stack usage by 2/3 on
samr21-xpro. Additionally, I removed the leading0xfor the hexadecimal numbers. The parsing script knows which numbers are hex (all of them) and they just waste time both on the node and in the parsing script.(
Needs to be adapted if #33 is merged beforedone)