Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

coap-chat: adapt to new gcoap API #74

Merged
merged 1 commit into from
Feb 5, 2021
Merged

coap-chat: adapt to new gcoap API #74

merged 1 commit into from
Feb 5, 2021

Conversation

leandrolanzieri
Copy link
Contributor

This adapts the coap-chat application to use the new gcoap API, as gcoap_finish has been deprecated and removed. Also, removes the inclusion of kernel_types.h which has been removed as well.

Test

Run the application following the README, it should compile and work as usual.

@leandrolanzieri leandrolanzieri mentioned this pull request Feb 4, 2021
Closed
3 tasks
@jia200x
Copy link
Member

jia200x commented Feb 4, 2021

it works!

> chat fe80::804e:b4ff:fe15:3164 jia200x "What do you call a fish without an eye?"
chat fe80::804e:b4ff:fe15:3164 jia200x "What do you call a fish without an eye?"

[ CHAT ] reply: a fsh

jia200x
jia200x approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x
Copy link
Member

jia200x commented Feb 4, 2021

something went wrong with Travis :/

@leandrolanzieri
Copy link
Contributor Author

Let's try restarting

@miri64
Copy link
Member

miri64 commented Feb 5, 2021

Mhhh Travis is failing with the same error on master for quite some time now, so it seems unrelated to this PR. The problem seems to be that it uses python 3.5 which is awefully outdated. It only does static checks anyway.

@miri64
Copy link
Member

miri64 commented Feb 5, 2021

It only does static checks anyway.

So, since @jia200x confirmed it to work, I think it is safe to merge :-).

@miri64 miri64 merged commit 24219f1 into RIOT-OS:master Feb 5, 2021
@leandrolanzieri leandrolanzieri deleted the pr/coap_chat/adapt_new_gcoap_api branch February 5, 2021 12:57
chrysn pushed a commit to chrysn-pull-requests/RIOT that referenced this pull request Sep 20, 2022
@miri64 @chrysn
Merge pull request RIOT-OS/applications#74 from leandrolanzieri/pr/co…
c71f74e 
…ap_chat/adapt_new_gcoap_api

coap-chat: adapt to new gcoap API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jia200x jia200x jia200x approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @jia200x @miri64