Add ZWSP between Telegram usernames #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tjzabel
added
new change
jwflory
reviewed
May 17, 2020
jwflory
reviewed
May 17, 2020
jwflory
reviewed
May 19, 2020
jwflory
reviewed
May 19, 2020
jwflory
added
needs changes
…ross platforms. ResolveUserName is now used instead of user.String() for retrieving username information. For additional details, see: 42wim/matterbridge#175.
Helper methods now better reflect their actions.
Zedjones
approved these changes
May 23, 2020
jwflory
reviewed
May 24, 2020
| @@ -28,6 +28,7 @@ type IRCSettings struct { | |||
| Suffix string `env:"IRC_SUFFIX" envDefault:">"` | |||
| ShowJoinMessage bool `env:"IRC_SHOW_JOIN_MESSAGE" envDefault:"true"` | |||
| ShowLeaveMessage bool `env:"IRC_SHOW_LEAVE_MESSAGE" envDefault:"true"` | |||
| ShowZWSP bool `env:"IRC_SHOW_ZWSP" envDefault:"true"` | |||
There was a problem hiding this comment.
Note: This needs to go into the env.example and our config glossary too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This Is
If a user has accounts on both IRC and Telegram with the same username, it is easy to ping oneself across platforms each time a message is sent. A zero-width space (ZWSP) is used to add an invisible differentiation between the usernames on these platforms to prevent cross-platform username pinging.
Developer Details
ResolveUserNameis now used instead ofuser.String()for retrieving username information.For additional details, see: 42wim/matterbridge#175.