Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in platform.c #5

Closed
pkepes opened this issue Mar 7, 2024 · 3 comments
Closed

Error in platform.c #5

pkepes opened this issue Mar 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pkepes
Copy link

pkepes commented Mar 7, 2024

At line 90 you wrote: ret = i2c_master_cmd_begin(I2C_NUM_1, cmd, 1000 / portTICK_PERIOD_MS);
It would be nicer if instead of I2C_NUM_1, p_platform->port would be given like in the other functions. It caused big trouble, because I use I2C port 0.

@RJRP44 RJRP44 added the bug Something isn't working label Mar 7, 2024
@RJRP44 RJRP44 self-assigned this Mar 7, 2024
@RJRP44
Copy link
Owner

RJRP44 commented Mar 7, 2024

Hi @pkepes, thanks for reporting this bug. It's true that I missed this one, sorry for the inconvenience, I'll post a new version tonight.
Have a nice day.

RJRP44 added a commit that referenced this issue Mar 7, 2024
@RJRP44
Copy link
Owner

RJRP44 commented Mar 7, 2024

@pkepes, a new version is available : vl53l5cx v2.0.4. Let me know if it worked for you.

@pkepes
Copy link
Author

pkepes commented Mar 14, 2024

Hello @RJRP44, it works fine now, thank you for the fast correction! I really appreciate your code.

@RJRP44 RJRP44 closed this as completed Mar 14, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants