Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

183: Add separate footer for dashboard, adjust size of usermenu icon #230

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Smixie
Copy link
Collaborator

@Smixie Smixie commented Dec 5, 2024

This pull request includes several changes to the frontend components, mainly focusing on updating the footer and adjusting some layout and style properties. The most important changes are summarized below:

Footer Update:

  • Replaced Footer with DashboardFooter in DashboardLayout.tsx and updated the import statement accordingly. [1] [2]
  • Added a new DashboardFooter component with links and social media icons.
  • Created a new CSS module DashboardFooterCentered.module.css for styling the new DashboardFooter component.

Style Adjustments:

  • Reduced the size of the user profile picture in the UserMenu component from 55 to 45.
  • Removed extra margins in the UserPage component to improve layout alignment.

@Smixie Smixie self-assigned this Dec 5, 2024
@Smixie Smixie linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Dec 5, 2024

Here's the code health analysis summary for commits 989ed02..9f270e8. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ Success
❗ 2 occurences introduced
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Member

@m-milek m-milek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to share the .module.css file between the two footers? I think they won't diverge at all in CSS. Maybe we should have something like components/footers, where both of them would sit and share CSS?

Don't take action about this before @SebastianNowak01 feedback.

@Smixie
Copy link
Collaborator Author

Smixie commented Dec 5, 2024

It is possible the only difference is that instead of the logo is an empty group, so I did not need to change any of the css.

Copy link
Collaborator

@SebastianNowak01 SebastianNowak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some thought and looking into module.css I think we can use just one module.css for both of these dashboards. So you can safely delete the dashboard module.css

@SebastianNowak01 SebastianNowak01 self-requested a review December 5, 2024 18:59
@Smixie Smixie requested a review from m-milek December 5, 2024 20:46
@m-milek m-milek merged commit aff9706 into dev Dec 6, 2024
15 checks passed
@m-milek m-milek deleted the 183-different-footer-for-dashboard-layout branch December 6, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different footer for dashboard layout
3 participants