185 database client for the backend #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
m-milek
force-pushed
the
185-database-client-for-the-backend
branch
from
716138f to
c86787c
Compare
m-milek
force-pushed
the
185-database-client-for-the-backend
branch
from
12ee382 to
afa9be6
Compare
# Conflicts: # backend/src/api/auth/login.rs # backend/src/api/report/generate.rs # backend/src/api/user/mod.rs # backend/src/auth/jwt.rs # backend/src/main.rs # backend/src/websocket/mod.rs # backend/src/websocket/peers.rs # backend/src/websocket/socket_handler.rs
SebastianNowak01
approved these changes
Dec 8, 2024
Smixie
approved these changes
Dec 8, 2024
katJablonska
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a fully functional database interface for persisting all domain types, including deeply nested structures such as reports and their associated items. This is a complex task in PostgreSQL—or any other database system—but the implementation here achieves it with an elegant and efficient design.
Key Features
Limitations
This PR primarily addresses the saving functionality for our domain types. Fetching operations are not covered here and will need to be implemented separately. However, fetching is expected to be less complex, especially for operations specific to a single type. For example, fetching a report by a specific criterion will require minimal additional effort.
Additional Notes
This is a significant and sizable PR, containing a substantial amount of code that reflects the complexity of the task. Despite this, the resulting implementation is both powerful and easy to use, addressing challenges that are otherwise difficult to solve in traditional database systems.