Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

221: Add basic error boundaries #238

Merged
merged 18 commits into from
Dec 9, 2024
Merged

221: Add basic error boundaries #238

merged 18 commits into from
Dec 9, 2024

Conversation

SebastianNowak01
Copy link
Collaborator

@SebastianNowak01 SebastianNowak01 commented Dec 8, 2024

This pull request includes multiple changes to enhance error handling, refactor code, and update dependencies in the frontend project. The most important changes include the addition of error boundaries, refactoring of the UserMenu component to use React Query, and updating the package.json and package-lock.json files with new dependencies.

Error Handling Enhancements:

  • Added react-error-boundary to handle errors gracefully in various components, including RateLimitStatus, UserMenu, About, and Dashboard pages. [1] [2] [3] [4] [5] [6] [7] [8]

Component Refactoring:

  • Refactored UserMenu to use React Query for fetching user data and improved error handling. [1] [2]
  • Replaced Box with Flex in Layout.tsx for better layout management.

Dependency Updates:

  • Updated package.json and package-lock.json to include react-error-boundary. [1] [2] [3]

New Fallback Components:

  • Added new fallback components for handling errors in ProfilePictureFallback, RateLimitStatusFallback, and UserMenuFallback. [1] [2] [3]

Schema Updates:

  • Updated field names in various schemas in types.ts to follow camelCase convention. [1] [2] [3]

@SebastianNowak01 SebastianNowak01 added help wanted Extra attention is needed frontend Related to the frontend testing Related to testing websocket tech debt addressing technical debt labels Dec 8, 2024
@SebastianNowak01 SebastianNowak01 self-assigned this Dec 8, 2024
@SebastianNowak01 SebastianNowak01 linked an issue Dec 8, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Dec 8, 2024

Here's the code health analysis summary for commits b8c2ae5..a8e9e30. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ Success
❗ 16 occurences introduced
🎯 8 occurences resolved
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@SebastianNowak01 SebastianNowak01 marked this pull request as ready for review December 9, 2024 19:59
Copy link
Collaborator

@Smixie Smixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me everything is good.

@m-milek m-milek changed the title 221: Add basic error boundries 221: Add basic error boundaries Dec 9, 2024
@Smixie Smixie self-requested a review December 9, 2024 20:52
@m-milek m-milek merged commit ea71d24 into dev Dec 9, 2024
15 checks passed
@m-milek m-milek deleted the 221-add-error-boundaries branch December 9, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to the frontend help wanted Extra attention is needed tech debt addressing technical debt testing Related to testing websocket
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Error Boundaries
3 participants