-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
221: Add basic error boundaries #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianNowak01
added
help wanted
Extra attention is needed
frontend
Related to the frontend
testing
Related to testing
websocket
tech debt
addressing technical debt
labels
Dec 8, 2024
Closed
Here's the code health analysis summary for commits Analysis Summary
|
…onnection to other sources
…in every component
…-tanstack-query' into 221-add-error-boundaries # Conflicts: # frontend/src/components/navbar/UserMenu.tsx # frontend/src/routes/user/page.tsx
# Conflicts: # frontend/src/components/navbar/UserMenu.tsx # frontend/src/routes/user/page.tsx
Smixie
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me everything is good.
m-milek
changed the title
221: Add basic error boundries
221: Add basic error boundaries
Dec 9, 2024
m-milek
requested changes
Dec 9, 2024
Smixie
reviewed
Dec 9, 2024
m-milek
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
Related to the frontend
help wanted
Extra attention is needed
tech debt
addressing technical debt
testing
Related to testing
websocket
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to enhance error handling, refactor code, and update dependencies in the frontend project. The most important changes include the addition of error boundaries, refactoring of the
UserMenu
component to use React Query, and updating thepackage.json
andpackage-lock.json
files with new dependencies.Error Handling Enhancements:
react-error-boundary
to handle errors gracefully in various components, includingRateLimitStatus
,UserMenu
,About
, andDashboard
pages. [1] [2] [3] [4] [5] [6] [7] [8]Component Refactoring:
UserMenu
to use React Query for fetching user data and improved error handling. [1] [2]Box
withFlex
inLayout.tsx
for better layout management.Dependency Updates:
package.json
andpackage-lock.json
to includereact-error-boundary
. [1] [2] [3]New Fallback Components:
ProfilePictureFallback
,RateLimitStatusFallback
, andUserMenuFallback
. [1] [2] [3]Schema Updates:
types.ts
to follow camelCase convention. [1] [2] [3]