Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

226 build and push nlp docker image gh action #251

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Smixie
Copy link
Collaborator

@Smixie Smixie commented Dec 14, 2024

This pull request includes changes to the GitHub Actions workflows to build and test the NLP Docker image and run Python NLP tests. The most important changes are the addition of a new workflow for building and pushing the NLP Docker image and modifications to the existing NLP test workflow.

GitHub Actions Workflows:

  • Added a new workflow for building and pushing the NLP Docker image on release. This includes steps for checking out the repository, logging into DockerHub, building the Docker image, and pushing the image to DockerHub. (.github/workflows/docker.yml)
  • Renamed the existing workflow to "Python NLP Tests" for clarity. (.github/workflows/nlp.yml)
  • Minor change to use double quotes consistently for the cache attribute in the Python setup step. (.github/workflows/nlp.yml)

@Smixie Smixie added the devops Related to CI/CD label Dec 14, 2024
@Smixie Smixie requested a review from m-milek December 14, 2024 19:39
@Smixie Smixie self-assigned this Dec 14, 2024
@Smixie Smixie linked an issue Dec 14, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Dec 14, 2024

Here's the code health analysis summary for commits 10c34c0..98e2619. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Smixie
Copy link
Collaborator Author

Smixie commented Dec 14, 2024

Workflow will run when release is created. With use of ${{ github.ref_name }} it should automatically get the new tag value v0.x.0. So there should be no need to change the value in variables.

@m-milek m-milek merged commit 524af2c into dev Dec 16, 2024
15 checks passed
@m-milek m-milek deleted the 226-build-and-push-nlp-docker-image---gh-action branch December 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and push NLP Docker image - GH Action
2 participants