Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

288 report state feedback and request refactor #293

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

m-milek
Copy link
Member

@m-milek m-milek commented Dec 23, 2024

This pull request includes significant changes to the backend, primarily focusing on database schema updates and refactoring of the report generation and user management logic. The changes involve updating SQL queries, modifying the database schema, and refactoring Rust code to accommodate these updates.

Database Schema Updates:

  • Updated the users table to replace the google_sub column with google_id and updated related queries accordingly.

  • Modified the reports table to include new columns is_successful, is_in_progress, is_error, and error_message, and updated related queries.

Refactoring:

  • Refactored Rust code to use new database schema and updated query parameters accordingly.

Removed Obsolete Queries:

  • Removed obsolete SQL queries that were no longer needed due to schema changes.

@m-milek m-milek added backend Related to the backend testing Related to testing database Related to our DB labels Dec 23, 2024
@m-milek m-milek self-assigned this Dec 23, 2024
@m-milek m-milek linked an issue Dec 23, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Dec 23, 2024

Here's the code health analysis summary for commits 63618e3..c4ca299. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Rust LogoRust✅ Success
❗ 29 occurences introduced
🎯 10 occurences resolved
View Check ↗
DeepSource JavaScript LogoJavaScript✅ Success
❗ 1 occurence introduced
🎯 2 occurences resolved
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@m-milek m-milek marked this pull request as ready for review December 23, 2024 19:22
Copy link
Collaborator

@SebastianNowak01 SebastianNowak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need a form input for description but other than that great job!

@m-milek m-milek linked an issue Dec 23, 2024 that may be closed by this pull request
@SebastianNowak01 SebastianNowak01 self-requested a review December 23, 2024 23:27
@SebastianNowak01 SebastianNowak01 merged commit ed3fe16 into dev Dec 23, 2024
16 checks passed
@SebastianNowak01 SebastianNowak01 deleted the 288-report-state-feedback branch December 23, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend database Related to our DB testing Related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report state feedback Fully support report descriptions
2 participants