-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
288 report state feedback and request refactor #293
Merged
Merged
+822
−376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/db/impls/report_repository.rs # frontend/src/routes/report/page/page.tsx
m-milek
added
backend
Related to the backend
testing
Related to testing
database
Related to our DB
labels
Dec 23, 2024
Closed
Here's the code health analysis summary for commits Analysis Summary
|
SebastianNowak01
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a form input for description but other than that great job!
SebastianNowak01
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the backend, primarily focusing on database schema updates and refactoring of the report generation and user management logic. The changes involve updating SQL queries, modifying the database schema, and refactoring Rust code to accommodate these updates.
Database Schema Updates:
Updated the
users
table to replace thegoogle_sub
column withgoogle_id
and updated related queries accordingly.Modified the
reports
table to include new columnsis_successful
,is_in_progress
,is_error
, anderror_message
, and updated related queries.Refactoring:
Removed Obsolete Queries: