Develop #149
Merged
Develop #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LeonJung
commented
Dec 1, 2017
LeonJung
commented
- Added : Deprecated is now being shown by attributes Inconvenient way of getting meaning of packet result and error value #67 [C++] Risk of memory leak in PacketHandler::getPacketHandler and PortHandler::getPortHandler #107
- Fixes : DynamixelSDK ROS Indigo Issue - target_sources func in CMake
- Fixes : Bug in protocol1_packet_handler.cpp, line 222 checking the returned Error Mask Bug in protocol1_packet_handler.cpp, line 222 checking the returned Error Mask #120
- Fixes : Packet Handlers - array param uint8_t to uint16_t to avoid closure loop when the packet is too long to be in uint8_t appropriately
- Fixes : Group Syncwrite using multiple ports in c library issue solved (test code is also in this issue bulletin) Group Syncwrite using multiple ports [help wanted] #124
- Fixes : Support getting of time on MacOSX/XCode versions that doesn't support (CLOCK_REALTIME issue) Error compiling SDK on Mac OSX: "use of undeclared identifier 'CLOCK_REALTIME'" #141 Support getting of time on MacOSX/XCode versions that don't support `… #144
- Changes : DynamixelSDK Ubuntu Linux usb ftdi latency timer fix issue - changes the default latency timer as 16 ms in all OS, but some about how to change the latency timer was commented in the codes (now the latency timer should be adjusted by yourself... see port_handler_linux source code to see details) fixed latency issue with serial port #116
This causes random trucated writes, where only 1 or 2 bytes of the packet are transmitted by the USB serial chip. I'm not exactly sure why; perhaps there is some kind of buffering that causes the flush command and write command to make it to the USB device out-of-order. In any case, I cannot see any reason why a flush should be necessary, especially on the TX buffer, so it's easy to remove
…the default latency timer from 16 msec to 2 msec (now the latency timer should be adjusted by yourself... see port_handler_linux source code to see details) #116
Support getting of time on MacOSX/XCode versions that doesn't support , and also solves'`Error compiling SDK on Mac OSX: "use of undeclared identifier 'CLOCK_REALTIME'" #141'
not to flush the tx buffer / Truncated packet transmission on OSX #142
…lved (test code is also in this issue bulletin) #124
…closure loop when the packet is too long to be in uint8_t appropriately
…closure loop when the packet is too long to be in uint8_t appropriately
…ed in the other languages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.