Turtlebot3Fake::init() should be invoked regardless ROS_ASSERT_ENABLED is defined. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROS_ASSERT could be no-op if it not ROS_ASSERT_ENABLED. Therefore, init() won't not be invoked under this condition. Suggest to rearrange the logic here.
seanyen
changed the title
|
Thank you for your contribution :) |
|
@routiful turtlebot3_drive.cpp and flat_world_imu_node.cpp also exhibit the same problems. Hope we can get quick fixes too. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS_ASSERT could be no-op if it not ROS_ASSERT_ENABLED. Therefore, init() won't not be invoked under this condition. Suggest to rearrange the logic here.