Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate __constant__ #1901

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Annotate __constant__ #1901

merged 4 commits into from
Mar 17, 2020

Conversation

AlexVlx
Copy link
Contributor

@AlexVlx AlexVlx commented Feb 28, 2020

No description provided.

This was referenced Feb 28, 2020
Closed
Open
scchan
scchan approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@scchan scchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scchan scchan added the pr:needs_updates PR initially approved. But needs rework label Mar 16, 2020
@mangupta mangupta merged commit eee5cc8 into master Mar 17, 2020
@mangupta mangupta deleted the feature_robust_constant branch March 17, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scchan scchan scchan approved these changes

@mangupta mangupta Awaiting requested review from mangupta

@bensander bensander Awaiting requested review from bensander

Assignees
No one assigned
Labels
pr:needs_updates PR initially approved. But needs rework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexVlx @scchan @mangupta