Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVCC inability to compile .hip files notice and workaround #3650

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jamesxu2
Copy link

@jamesxu2 jamesxu2 commented Oct 28, 2024

This docs change serves to clarify an error encountered when attempting to compile .hip files with nvcc, through hipcc.

e.g: As encountered by user in #3582

@jamesxu2
Copy link
Author

This will probably need to be consolidated around a separate FAQ-rewrite PR, once that gets merged: #3596

docs/how-to/faq.md Outdated Show resolved Hide resolved
@jamesxu2 jamesxu2 changed the base branch from amd-staging to docs/staging November 8, 2024 19:30
@jamesxu2 jamesxu2 changed the base branch from docs/staging to docs/develop November 8, 2024 19:33
@jamesxu2
Copy link
Author

jamesxu2 commented Nov 8, 2024

@MKKnorr I have revised this change per @yxsamliu's and your comments. It has also been rebased to docs/develop instead of amd-staging to account for the moved how-to/faq.md to root/faq.rst.

@neon60
Copy link
Contributor

neon60 commented Nov 18, 2024

@MKKnorr I have revised this change per @yxsamliu's and your comments. It has also been rebased to docs/develop instead of amd-staging to account for the moved how-to/faq.md to root/faq.rst.

@MKKnorr What is the status of this PR?

@MKKnorr
Copy link

MKKnorr commented Nov 20, 2024

Sorry, the updates of this PR slipped by me! If you rebase I'll take another look. Sorry for the delay!

@jamesxu2
Copy link
Author

jamesxu2 commented Nov 20, 2024

Apologies, my attempt to git rebase to the head of docs/develop somehow pulled in commits from the top of docs/develop that appear "new" and prevent merging... I'll spend some time trying to un-footgun myself later this afternoon

Edit: This seems fixed by a force-push

@MKKnorr You can take another look when you have time.

@jamesxu2 jamesxu2 force-pushed the jamesxu2/faq_nvcc_hip_file_extension branch from 56cbf1a to f90a77e Compare November 20, 2024 16:49
Copy link

@MKKnorr MKKnorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation is good, I would just move it to the compiler related section. Either add a new subsection for it, or you could as well add add the warning to hipcc-detected-my-platform-incorrectly-what-should-i-do

@jamesxu2
Copy link
Author

@MKKnorr , the warning has been moved to the section entitled "hipcc detected my platform incorrectly. What should I do?".

Are any other changes needed?

@MKKnorr
Copy link

MKKnorr commented Nov 22, 2024

@MKKnorr , the warning has been moved to the section entitled "hipcc detected my platform incorrectly. What should I do?".

Are any other changes needed?

Thanks! Nope, looks good as it is

@jamesxu2 jamesxu2 merged commit b864bbb into docs/develop Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Only run Read the Docs CI on this PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants