Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comgr: fix compiling with HIP SDK 5.5+ on Windows #2364

Merged
merged 3 commits into from
Oct 19, 2023
Merged

comgr: fix compiling with HIP SDK 5.5+ on Windows #2364

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1c955
comgr: fix compiling with HIP SDK 5.5+ on Windows
apwojcik Aug 31, 2023
a5b2394
Merge branch 'develop' into comgr_for_5.5
apwojcik Sep 18, 2023
d3dce26
Merge branch 'develop' into comgr_for_5.5
junliume Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/comgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#include <miopen/solver/implicitgemm_util.hpp>
#include <miopen/stringutils.hpp>

#if HIP_PACKAGE_VERSION_FLAT >= 5004000000ULL
#if !defined(_WIN32) && (HIP_PACKAGE_VERSION_FLAT >= 5004000000ULL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in Windows the location of amd_comgr.h does not correspond to the one in Linux? Is it a bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a bug. We must build comgr from source code on Windows. We're talking with the respective people from HIP SDK not to build the comgr on our own. We prefer they provide the package instead. But that discussion has just started, and it is pending.

#include <amd_comgr/amd_comgr.h>
#else
#include <amd_comgr.h>
Expand Down