Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test non-packed inputs with naive reference convolution kernels #2394

Merged
merged 38 commits into from
Oct 12, 2023

Commits on Sep 22, 2023

  1. Squash commits together

    replace constant with appropriate block dimension
    
    WIP: add strides as a kernel parameter for non-packed tensors
    
    WIP: created non-packed variants for remaining 3D conv kernels
    
    fix: treat input and output as 6D NDHWGC tensor
    
    use std::call_once for initializing random seed
    
    revamp naive kernels to use strides in the non-packed tensors case (controlled by a bool flag)
    
    WIP: fixed kernel compilation issues but unable to load kernel code object
    
    WIP: fixed issue with hip rtc
    
    split channel strides into group, channels_per_group in solver
    
    fix indexing to left-to-right order
    
    fix bug with too much padding between kernel args
    
    num channels should be a multiple of num groups
    
    re-enable naive ref kernels with strides array
    
    2D forward tests are all working now
    
    WIP: debugging bwd tests
    
    WIP: tests up till 3D bwd conv passing
    
    fix bug in bwd ndhwc kernel
    
    fix formatting
    
    disable prints
    
    fix readability-inconsistent-declaration-parameter-name
    
    fix clang-format
    
    fix hip tidy issue
    
    reverting the change to static init of random seed
    
    address comments and tidy issues. Remove extra print
    
    removed blank line change
    
    remove unneeded include
    
    env var for choosing packed vs non-packed reference kernel
    
    fix warnings from hip-tidy
    
    address comment about array initialization
    
    clear a tiny hip tidy issue
    amberhassaan committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    94f5fd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Configuration menu
    Copy the full SHA
    5ab82f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be93522 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    d85785b View commit details
    Browse the repository at this point in the history
  2. Squash commits together

    replace constant with appropriate block dimension
    
    WIP: add strides as a kernel parameter for non-packed tensors
    
    WIP: created non-packed variants for remaining 3D conv kernels
    
    fix: treat input and output as 6D NDHWGC tensor
    
    use std::call_once for initializing random seed
    
    revamp naive kernels to use strides in the non-packed tensors case (controlled by a bool flag)
    
    WIP: fixed kernel compilation issues but unable to load kernel code object
    
    WIP: fixed issue with hip rtc
    
    split channel strides into group, channels_per_group in solver
    
    fix indexing to left-to-right order
    
    fix bug with too much padding between kernel args
    
    num channels should be a multiple of num groups
    
    re-enable naive ref kernels with strides array
    
    2D forward tests are all working now
    
    WIP: debugging bwd tests
    
    WIP: tests up till 3D bwd conv passing
    
    fix bug in bwd ndhwc kernel
    
    fix formatting
    
    disable prints
    
    fix readability-inconsistent-declaration-parameter-name
    
    fix clang-format
    
    fix hip tidy issue
    
    reverting the change to static init of random seed
    
    address comments and tidy issues. Remove extra print
    
    removed blank line change
    
    remove unneeded include
    
    env var for choosing packed vs non-packed reference kernel
    
    fix warnings from hip-tidy
    
    address comment about array initialization
    
    clear a tiny hip tidy issue
    amberhassaan committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ee6abb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fbcd77 View commit details
    Browse the repository at this point in the history
  4. fix format

    amberhassaan committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    82e0ccf View commit details
    Browse the repository at this point in the history
  5. Fix assertion check.

    Co-authored-by: Alex Eremin <CAHEK7@yandex.ru>
    amberhassaan and CAHEK7 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7e8a258 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cadfb95 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cde6e22 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f7b606b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0ad674b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4db6cf8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8af6d47 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    e06c523 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23d0066 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    35c9072 View commit details
    Browse the repository at this point in the history
  4. address comments

    amberhassaan committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    67d9a77 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. address review comments

    amberhassaan committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0f16c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c66da71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8bb3a7f View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    dec88a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Configuration menu
    Copy the full SHA
    700b623 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1253aed View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    85e8a62 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    39eee97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f60f182 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7c9d03 View commit details
    Browse the repository at this point in the history
  4. address comments

    amberhassaan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    57fdf6e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Configuration menu
    Copy the full SHA
    e8dbc49 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. address comments

    amberhassaan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b5d8b0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fe1a55 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1cab2c3 View commit details
    Browse the repository at this point in the history
  4. fix build

    amberhassaan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    505f6ab View commit details
    Browse the repository at this point in the history
  5. fix Clang Format issue

    junliume committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c34c72a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    e146046 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    220e423 View commit details
    Browse the repository at this point in the history
  3. advance fin

    amberhassaan committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    baa2da4 View commit details
    Browse the repository at this point in the history