-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test non-packed inputs with naive reference convolution kernels #2394
Merged
Commits on Sep 22, 2023
-
replace constant with appropriate block dimension WIP: add strides as a kernel parameter for non-packed tensors WIP: created non-packed variants for remaining 3D conv kernels fix: treat input and output as 6D NDHWGC tensor use std::call_once for initializing random seed revamp naive kernels to use strides in the non-packed tensors case (controlled by a bool flag) WIP: fixed kernel compilation issues but unable to load kernel code object WIP: fixed issue with hip rtc split channel strides into group, channels_per_group in solver fix indexing to left-to-right order fix bug with too much padding between kernel args num channels should be a multiple of num groups re-enable naive ref kernels with strides array 2D forward tests are all working now WIP: debugging bwd tests WIP: tests up till 3D bwd conv passing fix bug in bwd ndhwc kernel fix formatting disable prints fix readability-inconsistent-declaration-parameter-name fix clang-format fix hip tidy issue reverting the change to static init of random seed address comments and tidy issues. Remove extra print removed blank line change remove unneeded include env var for choosing packed vs non-packed reference kernel fix warnings from hip-tidy address comment about array initialization clear a tiny hip tidy issue
Configuration menu - View commit details
-
Copy full SHA for 94f5fd3 - Browse repository at this point
Copy the full SHA 94f5fd3View commit details
Commits on Sep 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ab82f3 - Browse repository at this point
Copy the full SHA 5ab82f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for be93522 - Browse repository at this point
Copy the full SHA be93522View commit details
Commits on Sep 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d85785b - Browse repository at this point
Copy the full SHA d85785bView commit details -
replace constant with appropriate block dimension WIP: add strides as a kernel parameter for non-packed tensors WIP: created non-packed variants for remaining 3D conv kernels fix: treat input and output as 6D NDHWGC tensor use std::call_once for initializing random seed revamp naive kernels to use strides in the non-packed tensors case (controlled by a bool flag) WIP: fixed kernel compilation issues but unable to load kernel code object WIP: fixed issue with hip rtc split channel strides into group, channels_per_group in solver fix indexing to left-to-right order fix bug with too much padding between kernel args num channels should be a multiple of num groups re-enable naive ref kernels with strides array 2D forward tests are all working now WIP: debugging bwd tests WIP: tests up till 3D bwd conv passing fix bug in bwd ndhwc kernel fix formatting disable prints fix readability-inconsistent-declaration-parameter-name fix clang-format fix hip tidy issue reverting the change to static init of random seed address comments and tidy issues. Remove extra print removed blank line change remove unneeded include env var for choosing packed vs non-packed reference kernel fix warnings from hip-tidy address comment about array initialization clear a tiny hip tidy issue
Configuration menu - View commit details
-
Copy full SHA for ee6abb3 - Browse repository at this point
Copy the full SHA ee6abb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fbcd77 - Browse repository at this point
Copy the full SHA 4fbcd77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82e0ccf - Browse repository at this point
Copy the full SHA 82e0ccfView commit details -
Co-authored-by: Alex Eremin <CAHEK7@yandex.ru>
Configuration menu - View commit details
-
Copy full SHA for 7e8a258 - Browse repository at this point
Copy the full SHA 7e8a258View commit details -
Configuration menu - View commit details
-
Copy full SHA for cadfb95 - Browse repository at this point
Copy the full SHA cadfb95View commit details -
Configuration menu - View commit details
-
Copy full SHA for cde6e22 - Browse repository at this point
Copy the full SHA cde6e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b606b - Browse repository at this point
Copy the full SHA f7b606bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ad674b - Browse repository at this point
Copy the full SHA 0ad674bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db6cf8 - Browse repository at this point
Copy the full SHA 4db6cf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af6d47 - Browse repository at this point
Copy the full SHA 8af6d47View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e06c523 - Browse repository at this point
Copy the full SHA e06c523View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23d0066 - Browse repository at this point
Copy the full SHA 23d0066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35c9072 - Browse repository at this point
Copy the full SHA 35c9072View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67d9a77 - Browse repository at this point
Copy the full SHA 67d9a77View commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f16c62 - Browse repository at this point
Copy the full SHA 0f16c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for c66da71 - Browse repository at this point
Copy the full SHA c66da71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb3a7f - Browse repository at this point
Copy the full SHA 8bb3a7fView commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dec88a7 - Browse repository at this point
Copy the full SHA dec88a7View commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 700b623 - Browse repository at this point
Copy the full SHA 700b623View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1253aed - Browse repository at this point
Copy the full SHA 1253aedView commit details
Commits on Oct 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 85e8a62 - Browse repository at this point
Copy the full SHA 85e8a62View commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 39eee97 - Browse repository at this point
Copy the full SHA 39eee97View commit details -
Configuration menu - View commit details
-
Copy full SHA for f60f182 - Browse repository at this point
Copy the full SHA f60f182View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c9d03 - Browse repository at this point
Copy the full SHA e7c9d03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57fdf6e - Browse repository at this point
Copy the full SHA 57fdf6eView commit details
Commits on Oct 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e8dbc49 - Browse repository at this point
Copy the full SHA e8dbc49View commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b5d8b0f - Browse repository at this point
Copy the full SHA b5d8b0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe1a55 - Browse repository at this point
Copy the full SHA 0fe1a55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cab2c3 - Browse repository at this point
Copy the full SHA 1cab2c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 505f6ab - Browse repository at this point
Copy the full SHA 505f6abView commit details -
Configuration menu - View commit details
-
Copy full SHA for c34c72a - Browse repository at this point
Copy the full SHA c34c72aView commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e146046 - Browse repository at this point
Copy the full SHA e146046View commit details -
Configuration menu - View commit details
-
Copy full SHA for 220e423 - Browse repository at this point
Copy the full SHA 220e423View commit details -
Configuration menu - View commit details
-
Copy full SHA for baa2da4 - Browse repository at this point
Copy the full SHA baa2da4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.