Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] fix fwd trans conv MakeFwdCtxAndProblem() intenal API #2476

Closed
wants to merge 5 commits into from
Closed

[HOTFIX] fix fwd trans conv MakeFwdCtxAndProblem() intenal API #2476

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02f6520
fix fwd trans conv get_workspace API
carlushuang Oct 23, 2023
791c271
Merge remote-tracking branch 'origin/develop' into fix_fwd_trans_get_…
carlushuang Oct 23, 2023
0816200
disable bwd_gemm solver
carlushuang Oct 23, 2023
377bdf3
Merge remote-tracking branch 'origin/develop' into fix_fwd_trans_get_…
carlushuang Oct 24, 2023
81ce1be
Revert "disable bwd_gemm solver"
carlushuang Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/convolution_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,8 @@ static inline auto MakeFwdCtxAndProblem(miopenHandle_t handle,
const auto direction =
(conv.mode != miopenTranspose) ? Direction::Forward : Direction::BackwardData;

auto problem = (conv.mode != miopenTranspose) ? ProblemDescription{miopen::deref(xDesc),
miopen::deref(wDesc),
miopen::deref(yDesc),
conv,
direction}
: ProblemDescription{miopen::deref(yDesc),
miopen::deref(wDesc),
miopen::deref(xDesc),
conv,
direction};
auto problem = ProblemDescription{
miopen::deref(xDesc), miopen::deref(wDesc), miopen::deref(yDesc), conv, direction};
Comment on lines +59 to +60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2476 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atamazov Is there any alternative we can compare as a quick patch fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junliume Fix is done, in local testing. ETA for PR is tomorrow morning


auto ctx = ExecutionContext{&miopen::deref(handle)};
problem.SetupFloats(ctx);
Expand Down