Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] disable bwd_gemm solver to fix 2474 #2477

Closed
wants to merge 4 commits into from
Closed

[HOTFIX] disable bwd_gemm solver to fix 2474 #2477

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
312793c
disable bwd_gemm solver
carlushuang Oct 23, 2023
7f2f6ae
Merge remote-tracking branch 'origin/develop' into hotfix_bwd_gemm
carlushuang Oct 23, 2023
d75aace
fix tidy error
carlushuang Oct 23, 2023
fa5a598
renaming the macro
carlushuang Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/solver/gemm_bwd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
MIOPEN_DECLARE_ENV_VAR(MIOPEN_CONV_PRECISE_ROCBLAS_TIMING)

#define WORKAROUND_MIOPENGEMM_ISSUE_59 1
#define WORKAROUND_MIOPENGEMM_ISSUE_2474 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define WORKAROUND_MIOPENGEMM_ISSUE_2474 1
#define WORKAROUND_ISSUE_2474 1

We do not use MIOpenGemm (GEMM backend for OpenCL) anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in fa5a598

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[resolved]


// copy from convolution.cpp
// Workaround for issue 1430.
Expand Down Expand Up @@ -245,7 +246,7 @@ size_t GemmBwd1x1_stride2::GetWorkspaceSize(const ExecutionContext& context,
bool GemmBwd1x1_stride2::IsApplicable(const ExecutionContext& context,
const conv::ProblemDescription& problem) const
{
#if MIOPEN_USE_GEMM
#if MIOPEN_USE_GEMM && !WORKAROUND_MIOPENGEMM_ISSUE_2474
if(!GemmBwdBase::IsApplicable(context, problem))
return false;

Expand Down Expand Up @@ -482,7 +483,8 @@ bool GemmBwd1x1_stride1::IsApplicableBeforeWorkaround(const ExecutionContext& co
bool GemmBwd1x1_stride1::IsApplicable(const ExecutionContext& context,
const conv::ProblemDescription& problem) const
{
#if MIOPEN_USE_GEMM && (!MIOPEN_USE_MIOPENGEMM || !WORKAROUND_MIOPENGEMM_ISSUE_59)
#if MIOPEN_USE_GEMM && (!MIOPEN_USE_MIOPENGEMM || !WORKAROUND_MIOPENGEMM_ISSUE_59) && \
!WORKAROUND_MIOPENGEMM_ISSUE_2474
return IsApplicableBeforeWorkaround(context, problem);
#else
std::ignore = context;
Expand Down Expand Up @@ -682,7 +684,7 @@ size_t GemmBwdRest::GetWorkspaceSize(const ExecutionContext& context,
bool GemmBwdRest::IsApplicable(const ExecutionContext& context,
const conv::ProblemDescription& problem) const
{
#if MIOPEN_USE_GEMM
#if MIOPEN_USE_GEMM && !WORKAROUND_MIOPENGEMM_ISSUE_2474
if(!GemmBwdBase::IsApplicable(context, problem))
return false;

Expand Down