Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenCL tests #2485

Closed
wants to merge 2 commits into from
Closed

Remove OpenCL tests #2485

wants to merge 2 commits into from

Conversation

xinlipn
Copy link
Contributor

@xinlipn xinlipn commented Oct 26, 2023

Remove OpenCL test from cTest

@xinlipn xinlipn self-assigned this Oct 26, 2023
@atamazov
Copy link
Contributor

@xinlipn Is is ready to merge? If not, then please convert this PR to draft. Thanks.

@atamazov
Copy link
Contributor

Why I am asking. This only removes regression test for issue 1012 (which is OCL specific indeed) but does not remove all OCL-specific tests. The PR should be either renamed or extended. Thanks.

@xinlipn
Copy link
Contributor Author

xinlipn commented Oct 27, 2023

Why I am asking. This only removes regression test for issue 1012 (which is OCL specific indeed) but does not remove all OCL-specific tests. The PR should be either renamed or extended. Thanks.

Hi @atamazov , I searched by keywords OPENCL, HIP_DISABLED, OCL_ENABLED, is_ocl_check, OCL_TEST_DEFAULT in test/CMakeLists.txt, this is the only test that shows up.

Is there any other tests/logic you'd suggest to remove?

@xinlipn
Copy link
Contributor Author

xinlipn commented Oct 27, 2023

@xinlipn Is is ready to merge? If not, then please convert this PR to draft. Thanks.

Please see my comment to the other question about more OPENCL tests. I can convert it to draft if you think there's more tests to be removed

@atamazov
Copy link
Contributor

@xinlipn

Is there any other tests/logic you'd suggest to remove?

Yes. I'll better show this in my PR #2490. Stay tuned.

atamazov
atamazov reviewed Oct 27, 2023
View reviewed changes
test/CMakeLists.txt
--disable-validation)

add_custom_test(test_regression_opencl_float_mi100 GFX900_DISABLED GFX906_DISABLED HIP_DISABLED GFX90A_DISABLED
# Issue #1012.
Copy link
Contributor

@atamazov atamazov Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinlipn BTW issue #1012 is not OCL-specific and this change needs to be reverted.

@atamazov
Copy link
Contributor

@xinlipn

Is there any other tests/logic you'd suggest to remove?

Yes. I'll better show this in my PR #2490. Stay tuned.

here it is 5bf9244

@atamazov
Copy link
Contributor

I think this can be closed

@junliume junliume closed this Oct 29, 2023
@junliume junliume deleted the sl/remove_ocl_test branch February 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atamazov atamazov atamazov left review comments

@alexandraBara alexandraBara Awaiting requested review from alexandraBara

@JehandadKhan JehandadKhan Awaiting requested review from JehandadKhan JehandadKhan is a code owner

Assignees

@xinlipn xinlipn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinlipn @atamazov @junliume