Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the f8 reference kernel issue that failed CI #2586

Merged
merged 20 commits into from
Dec 7, 2023
Merged

Fix the f8 reference kernel issue that failed CI #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f555bbf
f8 fwd integration
iq136boy Oct 31, 2023
2927af0
add and fix f8 conv bwd solver
iq136boy Nov 6, 2023
add7b4c
f8 fwd, bwd, wrw solvers with gtests
iq136boy Nov 16, 2023
d07a1e9
minor fix for name confusion
iq136boy Nov 16, 2023
86c1511
merge develop
iq136boy Nov 20, 2023
cb92623
minor format fix
iq136boy Nov 20, 2023
95fed26
minor fix
iq136boy Nov 20, 2023
4438e6a
fix bug
iq136boy Nov 20, 2023
1e71229
fix after merge with develop
iq136boy Nov 21, 2023
8db6680
Merge branch 'develop' into dfeng/ck_f8_conv_2d
junliume Nov 23, 2023
42bdf85
fix CK API issues for new ck commit hash
iq136boy Nov 30, 2023
241f25a
address comments
iq136boy Nov 30, 2023
8246294
pull to fix diverge
iq136boy Nov 30, 2023
21c73d2
Merge branch 'develop' into dfeng/ck_f8_conv_2d
junliume Nov 30, 2023
dfed7c7
merge develop
iq136boy Nov 30, 2023
3c95c5b
Merge branch 'dfeng/ck_f8_conv_2d' of https://github.com/ROCmSoftware…
iq136boy Nov 30, 2023
f7beaf7
minor fix
iq136boy Nov 30, 2023
7ba693c
Merge branch 'develop' into dfeng/ck_f8_conv_2d
iq136boy Dec 1, 2023
8941406
fix the undefined behavior err in f8 reference kernel
iq136boy Dec 5, 2023
d7ed856
merge develop
iq136boy Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/kernels/hip_f8_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,13 @@ MIOPEN_HIP_HOST_DEVICE uint8_t cast_to_f8(T _x, bool stoch, uint32_t rng)
}
mantissa += (1 << mfmt); // Add the implicit 1 into mantissa
}
const long tmp = (mfmt - wm + exponent_diff);
if(tmp == 33)
printf("Gotcha");

bool midpoint = (mantissa & ((static_cast<uint32_t>(1) << (mfmt - wm + exponent_diff)) - 1)) ==
(static_cast<uint32_t>(1) << (mfmt - wm + exponent_diff - 1));
bool midpoint;
if(exponent_diff <= wm)
midpoint = (mantissa & ((1 << (mfmt - wm + exponent_diff)) - 1)) ==
(1 << (mfmt - wm + exponent_diff - 1));
else
midpoint = false;
/* This part is a bit tricky. The judgment of whether it is a tie needs to be done before we
shift right as shift right could rip off some residual part and make something not midpoint
look like midpoint. For example, the fp16 number 0x1002 (0 00100 0000000010), it is larger
Expand Down
9 changes: 8 additions & 1 deletion test/gtest/conv_f8_bwd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,14 @@

std::vector<Conv3DTestCase> ConvTestConfigs()
{ // g n c d h w k z y x pad_x pad_y pad_z stri_x stri_y stri_z dia_x dia_y dia_z
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 128, 64, 1, 28, 28, 64, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 32, 1, 28, 28, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{32, 128, 32, 1, 28, 28, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{16, 128, 16, 1, 28, 28, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{8, 128, 8, 1, 28, 28, 8, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{4, 128, 4, 1, 28, 28, 4, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{2, 128, 2, 1, 28, 28, 2, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
}

template <typename T = float>
Expand Down
7 changes: 6 additions & 1 deletion test/gtest/conv_f8_fwd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@

std::vector<Conv3DTestCase> ConvTestConfigs()
{ // g n c d h w k z y x pad_x pad_y pad_z stri_x stri_y stri_z dia_x dia_y dia_z
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 64, 1, 14, 14, 64, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 32, 1, 28, 28, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{2, 128, 32, 1, 28, 28, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{32, 128, 32, 1, 28, 28, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{5, 120, 60, 1, 28, 28, 60, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
}

template <typename T = float>
Expand Down
9 changes: 8 additions & 1 deletion test/gtest/conv_f8_wrw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,14 @@

std::vector<Conv3DTestCase> ConvTestConfigs()
{ // g n c d h w k z y x pad_x pad_y pad_z stri_x stri_y stri_z dia_x dia_y dia_z
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
return {{1, 16, 16, 1, 14, 14, 16, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 128, 1, 28, 3, 128, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 64, 1, 28, 3, 64, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 32, 64, 1, 14, 14, 64, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 32, 32, 1, 14, 14, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 64, 32, 1, 14, 14, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 128, 64, 1, 7, 7, 64, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution},
{1, 128, 32, 1, 7, 7, 32, 1, 3, 3, 1, 1, 0, 1, 1, 1, 1, 1, 1, miopenConvolution}};
}

template <typename T = float>
Expand Down