Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm 6.1 RC] Fix build failures. [quality] Reorg standard includes in HIP sources. #2637

Merged
merged 62 commits into from
Dec 26, 2023
Merged

[ROCm 6.1 RC] Fix build failures. [quality] Reorg standard includes in HIP sources. #2637

merged 62 commits into from
Dec 26, 2023

Commits on Nov 11, 2023

  1. Update docker and miopen version

    @atamazov @junliume
    atamazov authored and junliume committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    309309b View commit details
    Browse the repository at this point in the history

  2. update FIN to develop

    @atamazov @junliume
    atamazov authored and junliume committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    61e1721 View commit details
    Browse the repository at this point in the history

  3. update a few more requirements

    @junliume
    junliume committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    58c4d97 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. overrisde existing installed files

    @junliume
    junliume committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    39572c0 View commit details
    Browse the repository at this point in the history

  2. purge CK before installing new

    @junliume
    junliume committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    4a011d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. fix hip tidy issues

    @junliume
    junliume committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    58f8d80 View commit details
    Browse the repository at this point in the history

  2. add a few missing ones

    @junliume
    junliume committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7eefad5 View commit details
    Browse the repository at this point in the history

  3. adopt review opinion

    @junliume
    junliume committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ed1a732 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Update CMakeLists.txt 

    Co-authored-by: JD <jahandad@gmail.com>
    @junliume @JehandadKhan
    junliume and JehandadKhan authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8053a0c View commit details
    Browse the repository at this point in the history

  2. fix issues typo and hiprtc header

    @junliume
    junliume committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f958b46 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into bump_version_fin

    @junliume
    junliume committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    08a1ca3 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Keep base docker at Ubuntu 20.04

    @junliume
    junliume committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    699cf08 View commit details
    Browse the repository at this point in the history

  2. Revert limitations on limits header

    @junliume
    junliume committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3e847da View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. add fixes

    @umangyadav
    umangyadav committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    72eb180 View commit details
    Browse the repository at this point in the history

  2. changes that works for MIGraphX

    @umangyadav
    umangyadav committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    10e9581 View commit details
    Browse the repository at this point in the history

  3. rever changes for checknumerics

    @umangyadav
    umangyadav committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f498789 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fp8_fix

    @umangyadav
    umangyadav authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8bc23eb View commit details
    Browse the repository at this point in the history

  5. Formatting

    @umangyadav
    umangyadav committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    69c0d99 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fp8_fix' into bump_version_fin

    @junliume
    junliume committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    aa09f36 View commit details
    Browse the repository at this point in the history

  7. update docker file

    @junliume
    junliume committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    cf02a64 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. avoid ldd conflicts

    @junliume
    junliume committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ebeef1d View commit details
    Browse the repository at this point in the history

  2. update CK commit hash

    @junliume
    junliume committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ee34b45 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'develop' into bump_version_fin

    @junliume
    junliume committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    dab5d3b View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. update dockerfile

    @junliume
    junliume committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c6b4352 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bump_version_fin

    @junliume
    junliume committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b35b497 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. update dockerfile

    @junliume
    junliume committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9990a5d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bump_version_fin

    @junliume
    junliume committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    5b00521 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. workaround build issues of CK

    @junliume
    junliume committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0133956 View commit details
    Browse the repository at this point in the history

  2. fix the real issue in compiling rocMLIR

    @junliume
    junliume committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    dc55bba View commit details
    Browse the repository at this point in the history

  3. bump CK commit hash

    @junliume
    junliume committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0d48eb3 View commit details
    Browse the repository at this point in the history

  4. WA for Issue 2600 and turn on smoke tests by default

    @junliume
    junliume committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    19b1a95 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. ROCm 6.0 replaces all __HIP_PLATFORM_HCC__ with __HIP_PLATFORM_AMD__

    @junliume
    junliume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    592d5cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bump_version_fin

    @junliume
    junliume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e74ed6d View commit details
    Browse the repository at this point in the history

  3. Update src/comgr.cpp 

    Co-authored-by: Artem Tamazov <artem.tamazov@gmail.com>
    @junliume @atamazov
    junliume and atamazov authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f92cd4c View commit details
    Browse the repository at this point in the history

  4. fix clang format issue

    @junliume
    junliume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b81d3a5 View commit details
    Browse the repository at this point in the history

  5. fix-hiprtc-60(01) Add and use miopen_cstdint.hpp

    @atamazov
    atamazov committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    ee4020e View commit details
    Browse the repository at this point in the history

  6. fix-hiprtc-60(02) [tests] Improve logging of testing parameters durin… 

    …g CMake phase
    @atamazov
    atamazov committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f669dca View commit details
    Browse the repository at this point in the history

  7. fix-hiprtc-60(03) Merge branch 'bump_version_fin' into fix-hiprtc-60 

    # RESOLVED Conflicts:
#	src/comgr.cpp
    @atamazov
    atamazov committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1ca863f View commit details
    Browse the repository at this point in the history

  8. fix-hiprtc-60(04) [test_handle_test] Expect 5.7.x

    @atamazov
    atamazov committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5756538 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. fix-hiprtc-60(05) Add and use miopen_type_traits.hpp. Use miopen_cstd… 

    …int.hpp in some kernels.
    @atamazov
    atamazov committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c81a237 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. fix-hiprtc-60(06) Add and use miopen_utility.hpp instead of <utility>

    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    50740d0 View commit details
    Browse the repository at this point in the history

  2. fix-hiprtc-60(07) [CMake] Log HIPRTC version

    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ae88a45 View commit details
    Browse the repository at this point in the history

  3. fix-hiprtc-60(08) [HIPRTC] Do not define __HIP_PLATFORM_HCC__ startin… 

    …g from HIP 6.0.0.
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4a3b7ce View commit details
    Browse the repository at this point in the history

  4. fix-hiprtc-60(09) [HIPRTC][PCH] More uses of miopen_type_traits.hpp a… 

    …nd miopen_cstdint.hpp. Got rid of <cmath>. Added todo about <limits>
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d0045b2 View commit details
    Browse the repository at this point in the history

  5. fix-hiprtc-60(10) [F8] Improved build time for device. Added todo wrt… 

    … fixing numeric_limits::min().
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1992ab3 View commit details
    Browse the repository at this point in the history

  6. fix-hiprtc-60(11) [HIPRTC][PCH] Improved miopen_cstdint.hpp. Prepare … 

    …the fix for ROCm 6.1 RC with outdated HIP version.
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d049055 View commit details
    Browse the repository at this point in the history

  7. fix-hiprtc-60(12) [test_handle_test] Expect ROCm 6.1 RC with outdated… 

    … HIP version.
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    cae396d View commit details
    Browse the repository at this point in the history

  8. fix-hiprtc-60(13) Formatting

    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f6502c3 View commit details
    Browse the repository at this point in the history

  9. fix-hiprtc-60(14) Merge branch 'develop' into fix-hiprtc-60 

    # RESOLVED Conflicts:
#	requirements.txt
#	src/comgr.cpp
#	test/handle_test.cpp
    @atamazov
    atamazov committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d1c0b96 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. [tests] Limit applicability of ConvFwdBiasActivAPI/ConvFwdBiasResAddA… 

    …ctivTest.ConvFusedAPI
    @atamazov
    atamazov committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f3e11f0 View commit details
    Browse the repository at this point in the history

  2. fix-hiprtc-60(15) Merge branch 'develop' into fix-hiprtc-60

    @atamazov
    atamazov committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f9a2cd0 View commit details
    Browse the repository at this point in the history

  3. fix-hiprtc-60(16) Merge branch 'fix-ConvFwdBiasResAddActivTest' into … 

    …fix-hiprtc-60
    @atamazov
    atamazov committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    44fd4ba View commit details
    Browse the repository at this point in the history

  4. fix-hiprtc-60(17) [HIPRTC][PCH] Add and use miopen_limits.hpp instead… 

    … of <limits>
    @atamazov
    atamazov committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    e59ae19 View commit details
    Browse the repository at this point in the history

  5. fix-hiprtc-60(18) [driver][tests] Fix F8 related build errors in gen_… 

    …subnorm()
    @atamazov
    atamazov committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    d349c2d View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. fix-hiprtc-60(19) [HIPRTC][PCH] For now, use only standard <limits> t… 

    …o avoid possibility of correctness or performance regressions
    @atamazov
    atamazov committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    d445a0b View commit details
    Browse the repository at this point in the history

  2. fix-hiprtc-60(20) Tidy fixes

    @atamazov
    atamazov committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    0d03807 View commit details
    Browse the repository at this point in the history

  3. fix-hiprtc-60(21) [gemm] Fix runtime error with debug build - remove … 

    …incorrect assertion
    @atamazov
    atamazov committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    af0eed9 View commit details
    Browse the repository at this point in the history

  4. fix-hiprtc-60(22) [NFC] Remove incorrect comment from miopen_type_tra… 

    …its.hpp
    @atamazov
    atamazov committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    3badc26 View commit details
    Browse the repository at this point in the history

  5. fix-hiprtc-60(23) [NFC][HIPRTC][quality] Dismiss WORKAROUND_ISSUE_HIP… 

    …RTC_TRUE_TYPE, use MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS instead
    @atamazov
    atamazov committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    0bcbe48 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. fix-hiprtc-60(24) [NFC][HIPRTC][quality] Add and use WORKAROUND_DONT_… 

    …USE_CUSTOM_LIMITS
    @atamazov
    atamazov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    b0df124 View commit details
    Browse the repository at this point in the history

  2. fix-hiprtc-60(25) Merge branch 'develop' into fix-hiprtc-60 

    # RESOLVED Conflicts:
#	test/gtest/CMakeLists.txt
    @atamazov
    atamazov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    afcece4 View commit details
    Browse the repository at this point in the history

  3. fix-hiprtc-60(26) Code clarity. <limits> leftover.

    @atamazov
    atamazov committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    07e095e View commit details
    Browse the repository at this point in the history