-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HotFix] Fix build errors on SLES due to incomplete C++17 support #3085
Conversation
* Remove gfx942 kernel cache * remove gfx942 from kernel cache list
test/gtest/execute_primitive.cpp
Outdated
@@ -24,7 +24,11 @@ | |||
* | |||
*******************************************************************************/ | |||
|
|||
#if __cplusplus >= 201703L && __has_include(<filesystem>) | |||
#include <filesystem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes in PR3085 on SLES container on MI200 node and no build errors found. Here's steps:
export CXX=/opt/rocm/llvm/bin/clang++ && cmake -DMIOPEN_BACKEND=HIP -DMIOPEN_TEST_FLAGS=--disable-verification-cache -DCMAKE_BUILD_TYPE=debug -DBUILD_DEV=On -DMIOPEN_TEST_DISCRETE=OFF -DMIOPEN_USE_MLIR=ON -DMIOPEN_GPU_SYNC=Off -DCMAKE_PREFIX_PATH="/root/MIOpen/install_dir;/opt/rocm" -DCMAKE_INCLUDE_PATH="/usr/include;/root/MIOpen/install_dir/include;/root/MIOpen/install_dir/cget/pkg/sqlite3/install/include" .. make -j$(nproc) check Build log: |
Aakash reported build errors as below.
2024-06-25T02:43:44.069186122Z /long_pathname_so_that_rpms_can_package_the_debug_info/src/extlibs/MLOpen/test/gtest/execute_primitive.cpp:27:10: fatal error: 'filesystem' file not found
2024-06-25T02:43:44.069229053Z 27 | #include
Here's the log
http://rocm-ci.amd.com/job/compute-stage2-build/5502/artifact/logs/miopen-hip_failed.log/*view*/