Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GCC8 linking issues with stdc++fs #3126

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix GCC8 linking issues with stdc++fs #3126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,10 @@ rocm_set_soversion(MIOpen ${MIOpen_SOVERSION})

clang_tidy_check(MIOpen)

if(HAS_LIB_STD_FILESYSTEM)
target_link_libraries(MIOpen PRIVATE stdc++fs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be only necessary at some legacy Linux distros and GCC 8?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. We could put conditionals on the compiler being GCC and version being < 8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we can't do that because our compiler is clang++. Rather this conditional has to go on something else, e.g., a version of libstdc++, which I don't know how to detect, so HAS_LIB_STD_FILESYSTEM is a good enough choice till then because it should only exist on older systems (I hope).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some extra details:

I think this will be fine on newer systems, and we are utilizing the solution from the original PR:

endif()

find_package(zstd)
if(zstd_FOUND)
target_link_libraries(MIOpen PRIVATE $<IF:$<TARGET_EXISTS:zstd::libzstd_shared>,zstd::libzstd_shared,zstd::libzstd_static>)
Expand Down