Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] forbid GPU tests without explicit datatypes #3282

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[TEST] forbid GPU tests without explicit datatypes #3282

merged 2 commits into from
Oct 1, 2024

Conversation

CAHEK7
Copy link
Contributor

@CAHEK7 CAHEK7 commented Sep 30, 2024

There is only one test which mixed different datatypes and thus had _NONE datatype suffix.

All _NONE tests must be CPU only unless we have significant reason to add GPU type agnostic tests.

It's a part of CPU-only stage for CI.

@junliume junliume merged commit d68dbc1 into develop Oct 1, 2024
144 checks passed
@junliume junliume deleted the C7/explicit_gpu_types branch October 1, 2024 21:07
BrianHarrisonAMD
BrianHarrisonAMD reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianHarrisonAMD BrianHarrisonAMD BrianHarrisonAMD left review comments

@junliume junliume junliume approved these changes

@Vsevolod1983 Vsevolod1983 Awaiting requested review from Vsevolod1983

@JehandadKhan JehandadKhan Awaiting requested review from JehandadKhan JehandadKhan is a code owner

Assignees
No one assigned
Labels
GTest TESTING_CI_PASSED urgency_high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CAHEK7 @junliume @BrianHarrisonAMD