[HotFix] fix MHA build #3333
Closed
[HotFix] fix MHA build #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghimireamd
approved these changes
Oct 24, 2024
|
I guess it can be merged when all the build stages have passed. There is no point to wait for the full tests, since there are no MHA-Dropout tests in our testsuite. |
junliume
approved these changes
Oct 24, 2024
Since #3326 has not been merged and that change appeared in #3332 I decided to create a separated PR with minimal changes to cover that particular issue. I don't mind getting that fix from another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
#3326 (comment)
and
https://github.com/ROCm/MIOpen/pull/3332/files#diff-67f8008978cd249ea1918c970041f7f5b2efafe089a48705fe1d68fd21cb5cb8
@junliume