Ipanfilo/fa support #96
Open
+85
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix an argument issue when flash_attn>=2.5.7 Signed-off-by: Li Tao <lit@nvidia.com> Co-authored-by: Li Tao <lit@nvidia.com> Co-authored-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Markus Schnoes <markus.schnoes@gmx.de> Co-authored-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
| @@ -12,7 +12,7 @@ | |||
| from test_fused_attn import ModelConfig | |||
| from transformer_engine.pytorch.attention import ( | |||
| _flash_attn_2_plus, | |||
| _flash_attn_2_3_plus, | |||
| _flash_attn_2_6_plus, | |||
There was a problem hiding this comment.
It seems that this is not used in this file?
There was a problem hiding this comment.
Oh, yes. It left from pre IFU 1.11 commit where THD was only skipped with 2.6+
There was a problem hiding this comment.
Oh, also, I think we need to merge the updates from the dev branch (now with IFU 1.11) to make sure there is no breakage from that.
There was a problem hiding this comment.
It has those changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is work-in-progress review for ROCm FlashAttn2 support
Fixes #9693
Type of change
Changes