Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ROCm5.3 branch for MIOpen #12

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Use ROCm5.3 branch for MIOpen #12

merged 1 commit into from
Oct 5, 2022

Conversation

jithunnair-amd
Copy link

@jithunnair-amd jithunnair-amd commented Oct 5, 2022

Using -eq instead of -ge seems more appropriate since we don't intend to use older MIOpen branches for newer ROCm releases anyway.

@jithunnair-amd jithunnair-amd merged commit 0468db5 into main Oct 5, 2022
@jataylo
Copy link

jataylo commented Oct 24, 2022

@jithunnair-amd pytorch#1169

Should we revert to -ge to support the 5.1.1 case? Otherwise the [build-docker-rocm (5.1.1)] job in upstream CI fails

pytorch#67 1.099 + [[ 50101 -eq 50300 ]]
pytorch#67 1.099 + [[ 50101 -eq 50200 ]]
pytorch#67 1.099 + [[ 50101 -eq 50100 ]]
pytorch#67 1.099 + [[ 50101 -eq 50000 ]]
pytorch#67 1.099 + [[ 50101 -eq 40500 ]]
pytorch#67 1.099 + [[ 50101 -eq 40300 ]]
pytorch#67 1.099 + [[ 50101 -eq 40200 ]]
pytorch#67 1.099 Unhandled ROCM_VERSION 5.1.1
pytorch#67 1.099 + echo 'Unhandled ROCM_VERSION 5.1.1'
pytorch#67 1.099 + exit 1
pytorch#67 ERROR: executor failed running [/bin/sh -c bash ./install_miopen.sh ${ROCM_VERSION} && rm install_miopen.sh]: exit code: 1
rocm_final 9/11] RUN bash ./install_miopen.sh 5.1.1 && rm install_miopen.sh:
executor failed running [/bin/sh -c bash ./install_miopen.sh ${ROCM_VERSION} && rm install_miopen.sh]: exit code: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants