Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFU-main-2024-02-22 #44

Merged
merged 213 commits into from
Feb 22, 2024
Merged

IFU-main-2024-02-22 #44

merged 213 commits into from
Feb 22, 2024

Conversation

jithunnair-amd
Copy link

@jithunnair-amd jithunnair-amd commented Feb 22, 2024

This IFU PR brings in the following notable changes for ROCm:

jithunnair-amd and others added 30 commits August 8, 2023 10:34
* Add aarch64 docker image build

* removing ulimit for PT workflow

* set aarch64 worker for docker build
By pinning conda version to 23.5.2 as latest(23.7.2 at this time) does not have a compatible version of `git` packages

Fixes pytorch#1473
As it's already done as part of `common/install_conda.sh` script
* Add numpy install

* Add numpy install
* Add hostedtoolcache purge step

* Change step name
* Add pytorch-triton-rocm as an install dependency for ROCm

* Update build_rocm.sh
* Add aarch64 to validation framework

* Add aarch64 to validation framework
* Add aarch64 to validation framework

* Add aarch64 to validation framework

* Add aarch64 to validation framework
* Add torchonly option to validation workflows

* fix typo
malfet and others added 29 commits January 18, 2024 16:15
By using `$(uname -m)` as suffix, which is arm64 on Apple Silicon and
x86 on Intel Macs
As earliest available for the platform is llvmdev-11
PyTorch for M1 is finally built with OpenMP, so it needs to depend on it
Use dynamic MKL on Windows and updated MKL to 2021.4.0
On conda python 3.12 use mkl 2023.1
* Add torchrec to promote s3 script

* Add torchrec version to release_version.sh
With pytorch/pytorch#114329 merged, we need to include hipblaslt library files within the ROCm wheel.
* Remove custom PyTorch build dependency logic on 3.11

* Add a smoke test for openmp
…ckage (pytorch#1696)

changing the conda openblas package from pthread version
to openmp version to match torch openmp runtime. The pthread
version was conflicting with the openmp runtime and causing
thread over-subscription and performance degradation.
@jithunnair-amd jithunnair-amd merged commit b2960e3 into main Feb 22, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.