Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wheel and libtorch build scripts #7

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Refactor wheel and libtorch build scripts #7

merged 2 commits into from
Oct 27, 2022

Commits on Sep 26, 2022

  1. Update to so patching for ROCm 

    Wildcard used in grep to grab the actual numbered so file referenced
in patchelf. This allows the removal of specifying the so number in
DEPS_LIST & DEPS_SONAME

This commit also adds the functionality for trimming so names to
build_libtorch.sh from build_common.sh
    @jataylo
    jataylo committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    a9f6655 View commit details
    Browse the repository at this point in the history

  2. Refactor to remove switch statement in build_rocm.sh 

    This commit refactors build_rocm.sh and brings in a few major updates:
 - No longer required to specify the full .so name (with number) for ROCm libraries
       - The .so versions are copied and the patching code will fix the links to point to this version
 - No longer required to specify paths for ROCm libraries allowing the removal of the large switch
       - Paths are acquired programmatically with find
 - No longer required to specify both the path and filename for the OS specific libraries
       - Programatically extract file name from the path
 - Automatically extract Tensile/Kernels files for the architectures specified in PYTORCH_ROCM_ARCH
   and any non-arch specific files e.g. TensileLibrary.dat
    @jataylo
    jataylo committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    21a6844 View commit details
    Browse the repository at this point in the history