Skip to content

Commit

Permalink
[X86] Use explicit X86::CondCode argument in EmitTest/EmitCmp/isX86CC…
Browse files Browse the repository at this point in the history
…Signed calls. NFC. (llvm#125493)

Helps identify the enum code during debugging.
  • Loading branch information
RKSimon authored Feb 4, 2025
1 parent 5ed5ada commit 841c9b7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2944,7 +2944,7 @@ bool X86::isOffsetSuitableForCodeModel(int64_t Offset, CodeModel::Model CM,
}

/// Return true if the condition is an signed comparison operation.
static bool isX86CCSigned(unsigned X86CC) {
static bool isX86CCSigned(X86::CondCode X86CC) {
switch (X86CC) {
default:
llvm_unreachable("Invalid integer condition!");
Expand Down Expand Up @@ -22975,7 +22975,7 @@ static bool isProfitableToUseFlagOp(SDValue Op) {

/// Emit nodes that will be selected as "test Op0,Op0", or something
/// equivalent.
static SDValue EmitTest(SDValue Op, unsigned X86CC, const SDLoc &dl,
static SDValue EmitTest(SDValue Op, X86::CondCode X86CC, const SDLoc &dl,
SelectionDAG &DAG, const X86Subtarget &Subtarget) {
// CF and OF aren't always set the way we want. Determine which
// of these we need.
Expand Down Expand Up @@ -23085,7 +23085,7 @@ static SDValue EmitTest(SDValue Op, unsigned X86CC, const SDLoc &dl,

/// Emit nodes that will be selected as "cmp Op0,Op1", or something
/// equivalent.
static SDValue EmitCmp(SDValue Op0, SDValue Op1, unsigned X86CC,
static SDValue EmitCmp(SDValue Op0, SDValue Op1, X86::CondCode X86CC,
const SDLoc &dl, SelectionDAG &DAG,
const X86Subtarget &Subtarget) {
if (isNullConstant(Op1))
Expand Down

0 comments on commit 841c9b7

Please sign in to comment.