Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang][OpenMP] Support declare target in the global filtering pass #106

Merged

Conversation

skatrak
Copy link

@skatrak skatrak commented Jul 1, 2024

This patch takes declare target information on global variables into account when performing global variable filtering for the device. This prevents 'any' and 'nohost' globals from being removed.

It fixes the failing lit test: flang/test/Lower/OpenMP/declare-target-data.f90.

Copy link

@DominikAdamski DominikAdamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronlieb ronlieb self-requested a review July 1, 2024 12:26
This patch takes declare target information on global variables into account
when performing global variable filtering for the device. This prevents 'any'
and 'nohost' globals from being removed.

It fixes the failing lit test: flang/test/Lower/OpenMP/declare-target-data.f90.
@skatrak skatrak force-pushed the atd/declare-target-global-filtering branch from 3a24053 to 3775509 Compare July 1, 2024 13:06
@skatrak skatrak requested a review from raghavendhra July 1, 2024 13:06
Copy link

@raghavendhra raghavendhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skatrak skatrak merged commit 2849ffc into ROCm:amd-trunk-dev Jul 2, 2024
2 of 4 checks passed
@skatrak skatrak deleted the atd/declare-target-global-filtering branch July 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants