[Flang][MLIR][OpenMP] Fix num_teams, num_threads, thread_limit lowering #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agozillon
approved these changes
Aug 6, 2024
This patch fixes lowering for the num_teams, num_threads and thread_limit clauses when inside of a target region and compiling for the host device. The current approach requires these to be attached to the parent MLIR omp.target operation. However, some incorrect checks based on the `evalHasSiblings()` helper function would result in these clauses being attached to the `omp.teams` or `omp.parallel` operation instead, triggering a verifier error. In this patch, these checks are updated to stop breaking when lowering combined `target teams [X]` constructs. Also, the `genTeamsClauses()` function is fixed to avoid processing num_teams and thread_limit twice, which probably resulted from a recent merge.
skatrak
force-pushed
the
num-teams-threads-limit
branch
from
34956b0
to
dbbfdba
Compare
|
Thank you @agozillon for your suggestions. When adding a set of tests I realized that verifier restrictions were too restrictive and that I can't think of a good generic way of identifying in MLIR the cases where these arguments should be attached to the parent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes lowering for the num_teams, num_threads and thread_limit clauses when inside of a target region and compiling for the host device.
The current approach requires these to be attached to the parent MLIR omp.target operation. However, some incorrect checks based on the
evalHasSiblings()helper function would result in these clauses being attached to theomp.teamsoromp.paralleloperation instead, triggering a verifier error.In this patch, these checks are updated to stop breaking when lowering combined
target teams [X]constructs. Also, thegenTeamsClauses()function is fixed to avoid processing num_teams and thread_limit twice, which probably resulted from a recent merge.