Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][OMPIRBuilder] Remove redundant initialization of IsTargetDevice #140

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

skatrak
Copy link

@skatrak skatrak commented Aug 14, 2024

This property of the OpenMPIRBuilderConfig is already initialized in the constructor for OMPInformationCache. This looks to be a leftover after a merge from main (comment here).

This property of the `OpenMPIRBuilderConfig` is already initialized in the
constructor for `OMPInformationCache`. This looks to be a leftover after a
merge from main (comment [here](llvm#67000 (comment))).
Copy link

@DominikAdamski DominikAdamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatrak skatrak merged commit 92dc51c into ROCm:amd-trunk-dev Aug 14, 2024
3 of 5 checks passed
@skatrak skatrak deleted the is-target-device branch August 14, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants