Skip to content

Commit

Permalink
Enable HDP and GDRCOPY flush by default
Browse files Browse the repository at this point in the history
  • Loading branch information
wenkaidu committed Dec 17, 2024
1 parent 40f7bd1 commit 447ab5c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/transport/net.cc
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ static ncclResult_t sendSetup(struct ncclComm* comm, struct ncclTopoGraph* graph
// GDRCOPY support: TAIL_ENABLE When enabled locates the RX proxy tail in CUDA memory
NCCL_PARAM(GdrCopySyncEnable, "GDRCOPY_SYNC_ENABLE", 1);
// GDRCOPY support: FLUSH_ENABLE When enabled uses a PCI-E read to flush GDRDMA buffers
NCCL_PARAM(GdrCopyFlushEnable, "GDRCOPY_FLUSH_ENABLE", 0);
NCCL_PARAM(GdrCopyFlushEnable, "GDRCOPY_FLUSH_ENABLE", 1);

/* Setup recv connector */
static ncclResult_t recvSetup(struct ncclComm* comm, struct ncclTopoGraph* graph, struct ncclPeerInfo* myInfo, struct ncclPeerInfo* peerInfo, struct ncclConnect* connectInfo, struct ncclConnector* recv, int channelId, int connIndex) {
Expand Down Expand Up @@ -1355,7 +1355,7 @@ static ncclResult_t sendProxyProgress(struct ncclProxyState* proxyState, struct
}

RCCL_PARAM(NetHdpFlush, "NET_HDP_FLUSH", 1);
RCCL_PARAM(NetGdrFlush, "NET_GDR_FLUSH", 1);
RCCL_PARAM(NetGdrFlush, "NET_GDR_FLUSH", 0);

static ncclResult_t recvProxyProgress(struct ncclProxyState* proxyState, struct ncclProxyArgs* args) {
#if defined(ENABLE_NPKIT) && defined(ENABLE_NPKIT_NET_COLLECT_POLL_CNT)
Expand Down

0 comments on commit 447ab5c

Please sign in to comment.