Modify cmake instruction in build from source #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-jnovotny
requested review from
wenkaidu,
gilbertlee-amd,
BertanDogancay and
corey-derochie-amd
lpaoletti
approved these changes
Dec 3, 2024
corey-derochie-amd
approved these changes
Dec 3, 2024
amd-jnovotny
added a commit
to amd-jnovotny/rccl
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 28594b2)
amd-jnovotny
added a commit
to amd-jnovotny/rccl
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 28594b2)
corey-derochie-amd
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Refactor RCCL install guide into several pages (#1427) * Refactor RCCL install guide into several pages * Changes from code review and new docker guide * Add missing entries to ToC * Minor fixes * Fix help strings * Edits after review and remove extra white space (cherry picked from commit bf7c130) * Update rccl changelog for 6.3.1 (#1433) * Update rccl changelog for 6.3.1 * Fix version number * Correct RCCL release version * Added details to 6.3.0 changelog --------- Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com> (cherry picked from commit e42f10a) * Modify cmake instruction in build from source (#1445) (cherry picked from commit 28594b2) * Add RCCL debugging guide (#1420) * Add RCCL debugging guide * Changes from external review * More edits from internal review * Additional edits * Minor correction * More changes after external review * Integrate index and ToC changes with incoming merge changes * Integrate feedback from management review * Minor edits from the internal review (cherry picked from commit 6d34fb7)
corey-derochie-amd
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Refactor landing page and move some info to What is RCCL (#1415) (cherry picked from commit 2d07f18) * Refactor RCCL install guide into several pages (#1427) * Refactor RCCL install guide into several pages * Changes from code review and new docker guide * Add missing entries to ToC * Minor fixes * Fix help strings * Edits after review and remove extra white space (cherry picked from commit bf7c130) * Update rccl changelog for 6.3.1 (#1433) * Update rccl changelog for 6.3.1 * Fix version number * Correct RCCL release version * Added details to 6.3.0 changelog --------- Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com> (cherry picked from commit e42f10a) * Modify cmake instruction in build from source (#1445) (cherry picked from commit 28594b2) * Add RCCL debugging guide (#1420) * Add RCCL debugging guide * Changes from external review * More edits from internal review * Additional edits * Minor correction * More changes after external review * Integrate index and ToC changes with incoming merge changes * Integrate feedback from management review * Minor edits from the internal review (cherry picked from commit 6d34fb7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
Internal
What were the changes?
Modifies the build command based on feedback to add -DCMAKE_BUILD_TYPE=Release
Why were the changes made?
The change was recommended by reviewers in #1427 after the PR was merged and endorsed by the sw team.
How was the outcome achieved?
Modified the relevant rst doc and the read me file (to keep them aligned)
Additional Documentation:
No functional changes. PR 1427 must be merged first.
Approval Checklist
Do not approve until these items are satisfied.