[SWDEV-497665] Blocked cudaMemcpyAsync race condition by synchronizing
#1447
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortP2pSetup` to avoid race condition with `cudaIpcOpenMemHandle` inside p2p `connect`. See `ncclP2pImportShareableBuffer`.
corey-derochie-amd
force-pushed
the
SWDEV-497665_fix-async-memcpy-crash
branch
from
0b707d6 to
22ecb8c
Compare
corey-derochie-amd
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
mustafabar,
thananon and
haripriya-amd
as code owners
wenkaidu
approved these changes
Dec 5, 2024
…between every iteration of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
Changed some
cudaMemcpyAsynccalls to be synchronized.Why were the changes made?
In anticipation of behavioural changes being introduced to
hipMemcpyAsyncin ROCm 6.3.How was the outcome achieved?
Switched calls to
cudaMemcpyAsyncto becudaMemcpyinncclTransportP2pSetupto avoid race condition withcudaIpcOpenMemHandleinside p2pconnect. SeencclP2pImportShareableBuffer.Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.