Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for new NCCL Net plugin API change #1472

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amd-jnovotny
Copy link
Contributor

Details

Do not mention proprietary info or link to internal work items in this PR.

Work item: Internal

What were the changes?
Update docs to reflect design changes

Why were the changes made?
Align NCCL docs with latest API implementation

How was the outcome achieved?
Update the relevant .rst file

Additional Documentation:
No functional changes. Can be merged into the design PR if so required.

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

@amd-jnovotny amd-jnovotny added the ci:docs-only Skip most non-docs CI checks for this PR label Dec 19, 2024
@amd-jnovotny amd-jnovotny requested a review from a team as a code owner December 19, 2024 15:55
@corey-derochie-amd
Copy link
Collaborator

I propose we roll this into #1426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Skip most non-docs CI checks for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants