Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: set RPM license type #1232

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Hotfix: set RPM license type #1232

merged 3 commits into from
Jan 25, 2022

Conversation

lawruble13
Copy link
Contributor

Summary of proposed changes:

  • Change requested by legal to specify the license type in RPM packages.
  • Changes to ensure compatibility with rocm-cmake

TorreZuk
TorreZuk approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if meets new requirements

@lawruble13 lawruble13 merged commit 60c5f03 into ROCm:release/rocm-rel-5.0 Jan 25, 2022
mlse-lib-jenkins pushed a commit that referenced this pull request Feb 15, 2022
@ROCmMathLibrariesBot @lawruble13
Hotfix: License & rocm-cmake fixes (#1232) (#1075)
3fd5d8b 
* set RPM license type

* Move license installation to rocm-cmake

* Switch component

Co-authored-by: Liam Wrubleski <Liam.Wrubleski@amd.com>
ROCmMathLibrariesBot pushed a commit that referenced this pull request Jun 22, 2022
@rkamd
Removed cpp guidelines references from documentation (#1232)
4245b77 
* Removed all the  references to the cpp guidelines from documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorreZuk TorreZuk TorreZuk approved these changes

@amcamd amcamd Awaiting requested review from amcamd amcamd is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@daineAMD daineAMD Awaiting requested review from daineAMD daineAMD is a code owner

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@zaliu zaliu Awaiting requested review from zaliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawruble13 @TorreZuk