Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Remove passing the device set to lazy load API #1411

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Hotfix: Remove passing the device set to lazy load API #1411

merged 1 commit into from
Apr 3, 2024

Conversation

rkamd
Copy link
Contributor

@rkamd rkamd commented Mar 25, 2024

Remove passing the list of devices to Lazy Loading API, due to following reasons,

  • Increases the initilaization time.
  • Resolves SWDEV-438929 - hipModuleNotFound error ( this is a workaround and root cause is still unknown)

Reverting this change might affect heterogeneous GPU support.

mahmoodw
mahmoodw approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mahmoodw mahmoodw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and working as a workaround to the ticket

@rkamd rkamd merged commit cefa4a9 into release/rocm-rel-6.1 Apr 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahmoodw mahmoodw mahmoodw approved these changes

@amcamd amcamd Awaiting requested review from amcamd amcamd is a code owner

@TorreZuk TorreZuk Awaiting requested review from TorreZuk TorreZuk is a code owner

@daineAMD daineAMD Awaiting requested review from daineAMD daineAMD is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@yoichiyoshida yoichiyoshida Awaiting requested review from yoichiyoshida yoichiyoshida is a code owner

@babakpst babakpst Awaiting requested review from babakpst babakpst is a code owner

@nakajee nakajee Awaiting requested review from nakajee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkamd @mahmoodw