Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Tensile Tag #672

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Conversation

saadrahim
Copy link
Member

No description provided.

Copy link
Contributor

@leekillough leekillough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is going to be common, perhaps the tag should be stored in a separate file so that CMakeLists.txt isn't changed often.

Or perhaps submodules should be used, so that the tag is stored inside Git.

@saadrahim
Copy link
Member Author

If this is going to be common, perhaps the tag should be stored in a separate file so that CMakeLists.txt isn't changed often.

Or perhaps submodules should be used, so that the tag is stored inside Git.

I concur, we should go to submodules. We can discuss by email.

@pfultz2
Copy link
Contributor

pfultz2 commented Aug 23, 2019

I concur, we should go to submodules. We can discuss by email.

Let me just say that submodules is not a very good solution from a user perspective as rocBLAS will no longer have source tarballs from github that would work, which will prevent us from listing rocBLAS in our requirements.txt. We also would not like to have to use git clone --recursive to get rocBLAS because it can be really slow(we need dont need the entire history of rocBLAS and Tensile when building rocBLAS in our CI).

I dont really see what the issue is with updating a CMakeLists.txt file vs another file vs a git submodule.

@saadrahim
Copy link
Member Author

Updating the tag for latest Tensile with the fix that broke Tensile for the past few days. Jenkins will confirm this overnight.

@saadrahim saadrahim merged commit ee6a16e into ROCm:develop Sep 4, 2019
@saadrahim saadrahim deleted the Aug232019_TensileTag branch September 4, 2019 15:38
mlse-lib-jenkins pushed a commit that referenced this pull request May 7, 2021
--ff-only merge hot-fix from rocBLAS/master to rocBLAS-internal/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants