Support signed and unsigned integer types in migraphx dialect #1692
+289
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
changed the title
dhernandez0
commented
Oct 31, 2024
| TrivialConverter<RsqrtOp, tosa::RsqrtOp>, | ||
| TrivialConverter<SigmoidOp, tosa::SigmoidOp>, | ||
| TrivialConverter<TanhOp, tosa::TanhOp>, QuantizeLinearConverter, | ||
| DeQuantizeLinearConverter, ConvertConverter, NegConverter, |
There was a problem hiding this comment.
DeQuantizeLinearConverter was duplicated
krzysz00
reviewed
Oct 31, 2024
| @@ -117,18 +117,14 @@ def MIGraphX_WhereOp : | |||
|
|
|||
| def MIGraphX_ConvertOp : | |||
| MIGraphX_Op<"convert">, | |||
| Arguments<(ins AnyMIXRShaped:$inA, UnitAttr:$zeroExtend)>, | |||
| Arguments<(ins AnyMIXRShaped:$inA)>, | |||
There was a problem hiding this comment.
I'd keep zeroExtend for the sake of backwards compatibilyt and remove it in a followup PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1692 +/- ##
===========================================
- Coverage 77.76% 77.66% -0.10%
===========================================
Files 100 100
Lines 27866 27953 +87
Branches 4063 4080 +17
===========================================
+ Hits 21671 21711 +40
- Misses 4540 4575 +35
- Partials 1655 1667 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change MIGraphX dialect to support singed and unsigned int types.
TODO: add more test (quantize) and e2e tests