Skip to content

Commit

Permalink
Fixed FileNotFound error when passing path to --install_dir while run…
Browse files Browse the repository at this point in the history
…ning rtest.py on windows (#561)

* Fixed FileNotFound error on windows

* --- (#562)

updated-dependencies:
- dependency-name: requests
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Enable external CI pipeline triggers (#560)

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

* Update Read the Docs config to Python 3.10 and latest rocm-docs-core (#564)

* cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (#568)

* Bump rocm-docs-core from 1.2.0 to 1.4.0 in /docs/sphinx (#569)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.2.0 to 1.4.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.2.0...v1.4.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed FileNotFound error on windows

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joseph Macaranas <145489236+amd-jmacaran@users.noreply.github.com>
Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Co-authored-by: Steve Leung <Steve.Leung@amd.com>
  • Loading branch information
5 people authored Jul 4, 2024
1 parent b49884d commit 529b8b6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
Documentation for rocPRIM is available at
[https://rocm.docs.amd.com/projects/rocPRIM/en/latest/](https://rocm.docs.amd.com/projects/rocPRIM/en/latest/).

## Unreleased rocPRIM-3.3.0 for ROCm 6.3.0

### Fixes
* Fixed an issue where while running rtest.py on windows and passing in an absolute path to --install_dir
causes FileNotFound error


## Unreleased rocPRIM-3.2.0 for ROCm 6.2.0

### Additions
Expand Down
6 changes: 4 additions & 2 deletions rtest.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/python3
"""Copyright 2021 Advanced Micro Devices, Inc.
"""Copyright (c) 2021-2024 Advanced Micro Devices, Inc. All rights reserved.
Run tests on build"""

import re
Expand Down Expand Up @@ -211,7 +211,9 @@ def batch(script, xml):
else:
if args.debug: build_type = "debug"
else: build_type = "release"
test_dir = f"{args.install_dir}//{build_type}//test"
# deal with windows pathing
install_dir = '//'.join(args.install_dir.split('\\'))
test_dir = f"{install_dir}//{build_type}//test"
fail = False
for i in range(len(script)):
cmdline = script[i]
Expand Down

0 comments on commit 529b8b6

Please sign in to comment.