Update ROCm-CMake tag #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake dependencies GIT_TAG for rocm-cmake needs to be adjusted to be compatible with the ROCM pasckage version 0.11.0 that's used elsewhere. The current version of rocm-cmake (6.1.2) requires ROCM package version 0.12.0. The rocm-cmake 6.0.2 tag is the latest one that still allows us to use ROCM package version 0.11.0.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
|
FYI, in #575 (comment) I have fixed it, so |
|
Thanks @Naraenda, that's great. Since your fix uses 6.1.2, it's better than this one. I can close this PR and mention yours in the Jira ticket for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake dependencies GIT_TAG for rocm-cmake needs to be adjusted to be compatible with the ROCM package version 0.11.0 that's used elsewhere.
The current version of rocm-cmake (6.1.2) requires ROCM package version 0.12.0. The rocm-cmake 6.0.2 tag is the latest one that still allows us to use ROCM package version 0.11.0.